From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754217AbcIISmr (ORCPT ); Fri, 9 Sep 2016 14:42:47 -0400 Received: from mout.web.de ([212.227.17.11]:58480 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754260AbcIISml (ORCPT ); Fri, 9 Sep 2016 14:42:41 -0400 To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> From: SF Markus Elfring Subject: [PATCH] ATM-iphase: Use kmalloc_array() in tx_init() Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini Message-ID: <87a58007-c560-eb8d-b268-5a25452a8daf@users.sourceforge.net> Date: Fri, 9 Sep 2016 20:42:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:xYDsqaB28YOxWXQzirNVzeDqG7QEiH+qfpRxuggqHmewTZ2vORq 93FW0pAfvXhtqneRgNGEpnLIYlbU0t7RSXgZzAb1jUoWUNi5vdlURh6335djlJCNUNGpgbF h/0TmDUDEdpZOL/vhB2wMwTy13hk6uxQV4HnqwiHPEIh/dVtOdCbV/oyt5r1I1BkQIC1YvS g/ecozS7I61FxcKRJvXWg== X-UI-Out-Filterresults: notjunk:1;V01:K0:3q2RdeofHzA=:eT9ydJ6FK/A/V+l+A59ovA /OfZBvz2U/m5h7SxCPVfFt4NCD6qu042CsgDnbhgJ1raoCbJ9G9wO+jPXJXOKMO63rX0Wa2lw tZEIqKKg3rTkTf9EyT4YZdPWVfS1XPXiTtb8/p5F9qqcZwqrd6vDEMoU1M535bIGp033Ku1Bj b3CBLfw1ITE0aLkA15DurrfOqjOnArbvAIlxesUqNQkPzpgGYOxMLMRrnqIZtrMKpHvqrrkqx 3+fPKxqgGf6CtUsjk72oYFENMFu1C+GA9NqgGdZbhGNWpIKsmq+N5QBwZsxxYiAj8JlxjCrAS OS/Q+6scoyftSzhbma+EQcGzl7Z6MZdBNqSSNF3MVhckXlbBbqzYEBtAy78hzkx8XZAixssCQ 4RbOA3SC+7Xr5JlHUEfrD7NngQvaarh9iBWUZq+3Xc9cZYl3Q7kcgnfgyTrNH9l+z6uvcLnum SRuEmzrwlUgHfOBqB+I6MqQU+FIiCPuakN/ZXaJzlTVUW87x4uzIqdydmL3SqQVRsvDib+YWm aNFnvSk+nwpPvTKiekqWqGtIVZSgUKFKvCkHQqhnzlP3M3UAOuZd1xLg5Szr7aZi9SyiCSQlR vikAPPZiSHB8XuWqIUa492nKxc7i8uGx1jYtu8h7g01Gky58hnv1Ytvt6FJnlQ/MmO6iMcDmH QYVnMzNHQaqr3CjcGC6xPuHdkFu/Y6kf5RLulw9t9zHr07rSzbqMm3ZRn1FfK4N+H946lka1W xBBVia2muX8po7T/dk7AaCNT4k7deoUKoHceoPihgUOnr5qpRF5AV6oqWsJkzY1Q0c762NmL/ pTMDSD3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 9 Sep 2016 20:40:16 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of data types by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/atm/iphase.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index 809dd1e..9d8807e 100644 --- a/drivers/atm/iphase.c +++ b/drivers/atm/iphase.c @@ -1975,7 +1975,9 @@ static int tx_init(struct atm_dev *dev) buf_desc_ptr++; tx_pkt_start += iadev->tx_buf_sz; } - iadev->tx_buf = kmalloc(iadev->num_tx_desc*sizeof(struct cpcs_trailer_desc), GFP_KERNEL); + iadev->tx_buf = kmalloc_array(iadev->num_tx_desc, + sizeof(*iadev->tx_buf), + GFP_KERNEL); if (!iadev->tx_buf) { printk(KERN_ERR DEV_LABEL " couldn't get mem\n"); goto err_free_dle; @@ -1995,8 +1997,9 @@ static int tx_init(struct atm_dev *dev) sizeof(*cpcs), DMA_TO_DEVICE); } - iadev->desc_tbl = kmalloc(iadev->num_tx_desc * - sizeof(struct desc_tbl_t), GFP_KERNEL); + iadev->desc_tbl = kmalloc_array(iadev->num_tx_desc, + sizeof(*iadev->desc_tbl), + GFP_KERNEL); if (!iadev->desc_tbl) { printk(KERN_ERR DEV_LABEL " couldn't get mem\n"); goto err_free_all_tx_bufs; @@ -2124,7 +2127,9 @@ static int tx_init(struct atm_dev *dev) memset((caddr_t)(iadev->seg_ram+i), 0, iadev->num_vc*4); vc = (struct main_vc *)iadev->MAIN_VC_TABLE_ADDR; evc = (struct ext_vc *)iadev->EXT_VC_TABLE_ADDR; - iadev->testTable = kmalloc(sizeof(long)*iadev->num_vc, GFP_KERNEL); + iadev->testTable = kmalloc_array(iadev->num_vc, + sizeof(*iadev->testTable), + GFP_KERNEL); if (!iadev->testTable) { printk("Get freepage failed\n"); goto err_free_desc_tbl; -- 2.10.0