From: "Will Newton" <will.newton@gmail.com>
To: "Hugh Dickins" <hugh@veritas.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: copy_page_range() with VM_LOCKED
Date: Mon, 10 Mar 2008 18:53:38 +0000 [thread overview]
Message-ID: <87a5b0800803101153n614b044btfe02be2c77d11b84@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0803101728470.3398@blonde.site>
On Mon, Mar 10, 2008 at 5:40 PM, Hugh Dickins <hugh@veritas.com> wrote:
> > mmap with MAP_LOCKED only promises the page will not be paged out, not
> > that the page will never fault but I would like to get that behaviour.
> >
> > Would it be possible to add VM_LOCKED to the above conditional so
> > copy_page_range would always copy VM_LOCKED vma page tables or would
> > that be considered insane and broken?
>
> It would be possible, but I don't think it would be justified - for
> everybody who wants your behaviour, there'll be others who want the
> current behaviour (and that condition reflects those cases on which
> correctness demands we do the copy).
>
> If you really want that, I think you'll have to patch your own kernel.
>
> But much much better, mlock that area in your child after the fork,
> since it isn't actually locked at present: that mlock will bring in
> the pages - not quite as efficiently as copy_page_range would have done,
> but as or more efficiently than the original mlock in the parent.
The reason I want to do this is to work around a silicon bug so I'd
rather keep the whole workaround in the kernel rather than hacking the
C library etc. I wasn't aware that the VM_LOCKED flag would be lost in
the child, it looks like I'll have to come up with a more creative
solution...
Thanks for taking the time to explain how this stuff fits together,
prev parent reply other threads:[~2008-03-10 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 16:26 Will Newton
2008-03-10 17:40 ` Hugh Dickins
2008-03-10 18:53 ` Will Newton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5b0800803101153n614b044btfe02be2c77d11b84@mail.gmail.com \
--to=will.newton@gmail.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®