mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Newton <will.newton@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Brownell <david-b@pacbell.net>,
	David Woodhouse <David.Woodhouse@intel.com>
Subject: [PATCH] mtd_dataflash: Fix probing of AT45DB321C chips.
Date: Wed, 4 Mar 2009 10:41:12 +0000	[thread overview]
Message-ID: <87a5b0800903040241k51f65a65p82a2da8f6de1c832@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

Commit 771999b65f79264acde4b855e5d35696eca5e80c broke support for probing
AT45DB321C flash chips. These chips do not support the "page size" status
bit, so if we match the JEDEC id return early.

Signed-off-by: Will Newton <will.newton@gmail.com>
---
 drivers/mtd/devices/mtd_dataflash.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/devices/mtd_dataflash.c
b/drivers/mtd/devices/mtd_dataflash.c
index d44f741..cd4781f 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -822,6 +822,8 @@ static struct flash_info *__devinit
jedec_probe(struct spi_device *spi)
 						return info;
 				}
 			}
+			else
+				return info;
 		}
 	}

-- 
1.5.5.2

[-- Attachment #2: 0001-mtd_dataflash-Fix-probing-of-AT45DB321C-chips.patch --]
[-- Type: application/octet-stream, Size: 942 bytes --]

From 1b34659677fdab0b03590d189afe1820d250f095 Mon Sep 17 00:00:00 2001
From: Will Newton <will.newton@gmail.com>
Date: Wed, 4 Mar 2009 10:29:19 +0000
Subject: [PATCH] mtd_dataflash: Fix probing of AT45DB321C chips.

Commit 771999b65f79264acde4b855e5d35696eca5e80c broke support for probing
AT45DB321C flash chips. These chips do not support the "page size" status
bit, so if we match the JEDEC id return early.

Signed-off-by: Will Newton <will.newton@gmail.com>
---
 drivers/mtd/devices/mtd_dataflash.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index d44f741..cd4781f 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -822,6 +822,8 @@ static struct flash_info *__devinit jedec_probe(struct spi_device *spi)
 						return info;
 				}
 			}
+			else
+				return info;
 		}
 	}
 
-- 
1.5.5.2


             reply	other threads:[~2009-03-04 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04 10:41 Will Newton [this message]
2009-03-04 20:53 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5b0800903040241k51f65a65p82a2da8f6de1c832@mail.gmail.com \
    --to=will.newton@gmail.com \
    --cc=David.Woodhouse@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®