mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Newton <will.newton@gmail.com>
To: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Commit f520360d93cdc37de5d972dac4bf3bdef6a7f6a7 may break hotplug
Date: Mon, 6 Apr 2009 14:05:39 +0100	[thread overview]
Message-ID: <87a5b0800904060605i3295b9c6m34daf0d4872ebe58@mail.gmail.com> (raw)

Hi Arjan,

This commit changes the behaviour when calling the hotplug helper from
UMH_WAIT_EXEC to UMH_NO_WAIT. Unfortunately this seems to be causing
occasional segfaults for me. I believe this is caused because the argv
passed to call_usermode_helper is allocated on the stack and so may be
overwritten by the time the actual exec occurs.

Would it be possible to get this commit reverted?

Thanks,

                 reply	other threads:[~2009-04-06 13:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5b0800904060605i3295b9c6m34daf0d4872ebe58@mail.gmail.com \
    --to=will.newton@gmail.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®