mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Newton <will.newton@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] connector: clean up grammar/style in documentation
Date: Thu, 16 Jul 2009 10:15:43 +0100	[thread overview]
Message-ID: <87a5b0800907160215x59ca8b4aj9a1d22b82d12e792@mail.gmail.com> (raw)
In-Reply-To: <1247696049-15699-2-git-send-email-vapier@gentoo.org>

On Wed, Jul 15, 2009 at 11:14 PM, Mike Frysinger<vapier@gentoo.org> wrote:
> The grammar in most of this file is slightly off, and some sections are
> hard to read due to lack of visual clues breaking up related material.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  Documentation/connector/connector.txt |  119 +++++++++++++++++----------------
>  1 files changed, 61 insertions(+), 58 deletions(-)
>
> diff --git a/Documentation/connector/connector.txt b/Documentation/connector/connector.txt
> index ad6e0ba..847f0d8 100644
> --- a/Documentation/connector/connector.txt
> +++ b/Documentation/connector/connector.txt
> @@ -5,10 +5,10 @@ Kernel Connector.
>  Kernel connector - new netlink based userspace <-> kernel space easy
>  to use communication module.
>
> -Connector driver adds possibility to connect various agents using
> -netlink based network.  One must register callback and
> -identifier. When driver receives special netlink message with
> -appropriate identifier, appropriate callback will be called.
> +The Connector driver adds makes it easy to connect various agents using a
> +netlink based network.  One must register a callback and an identifier.
> +When the driver receives a special netlink message with the appropriate
> +identifier, the appropriate callback will be called.

The first line of the second paragraph still needs work, "adds" should
probably be removed.

  reply	other threads:[~2009-07-16  9:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 22:14 [PATCH 1/3] connector: make callback argument type explicit Mike Frysinger
2009-07-15 22:14 ` [PATCH 2/3] connector: clean up grammar/style in documentation Mike Frysinger
2009-07-16  9:15   ` Will Newton [this message]
2009-07-16 17:58     ` [PATCH 2/3 v2] " Mike Frysinger
2009-07-15 22:14 ` [PATCH 3/3] connector: get test code working by default Mike Frysinger
2009-07-16 10:19 ` [PATCH 1/3] connector: make callback argument type explicit Evgeniy Polyakov
2009-07-17 17:15   ` David Miller
2009-07-18  3:45     ` Mike Frysinger
2009-07-18  5:33       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5b0800907160215x59ca8b4aj9a1d22b82d12e792@mail.gmail.com \
    --to=will.newton@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®