From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6BBEB64DA for ; Wed, 5 Jul 2023 08:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231887AbjGEIzm (ORCPT ); Wed, 5 Jul 2023 04:55:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbjGEIzj (ORCPT ); Wed, 5 Jul 2023 04:55:39 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DB81713 for ; Wed, 5 Jul 2023 01:55:39 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AE0DD1F890; Wed, 5 Jul 2023 08:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688547337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eOmyEHyr0iiLqxM6ByyiTsEOHbd3rdaDe+tLZlMSH6U=; b=pHWlUw1nB4HYwtHIKr0PUn2rqxsjFSE0f3F8ydhxzB1QeKnkTRzRDN7sANSCxHOVYJ7cux Qwt8MaBUPXiDd4Y3FWMdRJQaluoLXy23zatuvkrzMdQ/Us+6O4j4aVdRQGUwtZgZ906LNd JpuQAuvakBrf6yH6Q0HTHtHfN1IckM4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688547337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eOmyEHyr0iiLqxM6ByyiTsEOHbd3rdaDe+tLZlMSH6U=; b=DmtXsj4z6R79cwOUnGi7y4vW3e0vTePbBmW0KSucdooEi3NIrfGlfEYw9Tls9ie7/NKO0d obFcaQK0WXRn2MCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78692134F3; Wed, 5 Jul 2023 08:55:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WsN6HAkwpWRAXAAAMHmgww (envelope-from ); Wed, 05 Jul 2023 08:55:37 +0000 Date: Wed, 05 Jul 2023 10:55:37 +0200 Message-ID: <87a5waohyu.wl-tiwai@suse.de> From: Takashi Iwai To: Minjie Du Cc: Jaroslav Kysela , Takashi Iwai , Stephen Rothwell , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list), opensource.kernel@vivo.com Subject: Re: [PATCH v1] sound: seq: check struct system assignment problem In-Reply-To: <20230705085022.13078-1-duminjie@vivo.com> References: <20230705085022.13078-1-duminjie@vivo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 05 Jul 2023 10:50:22 +0200, Minjie Du wrote: > > make data->system.parm1 avoid double assignment. > but note writes "RT message with two parameters to UMP" > is one of assignment is for system.parm2? Yes, that should be rather parm2. Could you resubmit with that typo fix instead? Thanks! Takashi > I'm not sure, Could you help check it out? > Thank you! > > > Signed-off-by: Minjie Du > --- > sound/core/seq/seq_ump_convert.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c > index eb1d86ff6..60e637149 100644 > --- a/sound/core/seq/seq_ump_convert.c > +++ b/sound/core/seq/seq_ump_convert.c > @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event, > unsigned char status) > { > data->system.status = status; > - data->system.parm1 = (event->data.control.value >> 7) & 0x7f; > data->system.parm1 = event->data.control.value & 0x7f; > return 1; > } > -- > 2.39.0 >