From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA88C433EF for ; Wed, 11 May 2022 13:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244114AbiEKNl1 (ORCPT ); Wed, 11 May 2022 09:41:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244065AbiEKNlT (ORCPT ); Wed, 11 May 2022 09:41:19 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 809A169283; Wed, 11 May 2022 06:41:15 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4KywzV4X1vz4xVP; Wed, 11 May 2022 23:41:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1652276471; bh=vEOI3XTsaBJEwMmKwOJuGXvPCXkgzyvATD8nzGoiPwk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RQdbtKH40fvudPGia+31Rz17OTRZJVD0hi6NxK819HG/TDwUTeLFxOiHPPArIIQTu 7PAxhZhTSa3L5c55LdD9mXQyOYdnRROB2tlAymjEDPrnwVpzeIdvUNY1sqcrD1a0BF RyZCt321zJTGqAI3b+qWLFBv/gB8roPW72j+MJf3Z+TmMQPPYrAp/pI1+XmN9heYFq fvrnyB99ikQEClAW9Ued7zthbWJgvCRsuX3xp93fh5La9LdDZTylJIeUkad7VYrowN y6SGgNbbxOf7xvjJmmHlcJoNOmcoTCbi57fpscMYTx+TEAjNGJ1plcAMrd8fzy00SQ 7pofjvVnsyVtw== From: Michael Ellerman To: Konstantin Ryabitsev , Linus Torvalds Cc: Nathan Chancellor , "Michael S. Tsirkin" , KVM list , virtualization@lists.linux-foundation.org, Netdev , Linux Kernel Mailing List , mie@igel.co.jp Subject: Re: [GIT PULL] virtio: last minute fixup In-Reply-To: <20220511125140.ormw47yluv4btiey@meerkat.local> References: <20220510082351-mutt-send-email-mst@kernel.org> <20220511125140.ormw47yluv4btiey@meerkat.local> Date: Wed, 11 May 2022 23:40:59 +1000 Message-ID: <87a6bo89w4.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Konstantin Ryabitsev writes: ... > > I think we should simply disambiguate the trailer added by tooling like b4. > Instead of using Link:, it can go back to using Message-Id, which is already > standard with git -- it's trivial for git.kernel.org to link them to > lore.kernel.org. But my mailer, editor and terminal don't know what to do with a Message-Id. Whereas they can all open an https link. Making people paste message ids into lore to see the original submission is not a win. People make enough fun of us already for still using email to submit patches, let's not make their job any easier :) > Before: > > Signed-off-by: Main Tainer > Link: https://lore.kernel.org/r/CAHk-=wgAk3NEJ2PHtb0jXzCUOGytiHLq=rzjkFKfpiuH-SROgA@mail.gmail.com > > After: > > Signed-off-by: Main Tainer > Message-Id: > > This would allow people to still use Link: for things like linking to actual > ML discussions. I know this pollutes commits a bit, but I would argue that > this is a worthwhile trade-off that allows us to improve our automation and > better scale maintainers. I went back through the history and I'm pretty sure that the original use for "Link:" was to link to the original submission, done by tip-bot starting back in 2011: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f994d99cf140dbb637e49882891c89b3fd84becd Prior to that there were no "Link:" tags, only "BugLink:". But if people want to reclaim "Link:" for generic links then fine, but let's still use a https link, just give it a different name. eg. "PatchLink:", or "Submitted:" etc. cheers