From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 421C0C47099 for ; Wed, 2 Jun 2021 08:38:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F8C3613D3 for ; Wed, 2 Jun 2021 08:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232718AbhFBIkg (ORCPT ); Wed, 2 Jun 2021 04:40:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58382 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230074AbhFBIkf (ORCPT ); Wed, 2 Jun 2021 04:40:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622623132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sTZTtBNUa2GqpMgr3TsfApPZ9E5Jnhf92Yl0Bbd6O1k=; b=N8NKZJLHztsTWaiI4i+o+1eRs3wBImf0FNCL46X8ETRW0WhO2D9zN9zq2m6jL2GEog/1iq mB5y4S/tgCm3O2TiydeYjaCZJwfL1KhmqwCiHlejg16v942CBzFj/gTDgjEljN4aiivxde l8J9IG2jj7BYxsAvqyFz0v1aV0P+g7I= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-d35jH_TrM_KDkz7ZCz1SXw-1; Wed, 02 Jun 2021 04:38:51 -0400 X-MC-Unique: d35jH_TrM_KDkz7ZCz1SXw-1 Received: by mail-ed1-f72.google.com with SMTP id h23-20020aa7c5d70000b029038fed7b27d5so956011eds.21 for ; Wed, 02 Jun 2021 01:38:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=sTZTtBNUa2GqpMgr3TsfApPZ9E5Jnhf92Yl0Bbd6O1k=; b=k12q/Wxu88Y5iX5t2x/3UItJTIKVceN3i5NduNnEQwVRPy3IPG42ZdN47l/N/Qg4Ci dN2ktqDQO3C9LuvY5M0O9DiqvyTrWrejfoPjQE7qIxd0GN/AgLvL68v37ig4HcbR+WOC 8SCn0mSU25SPy92d23/Uyf2gd4QoLR0Rp9ELImcYBeb8rLwNF9Uvy+k85VYAZDJouUTh z8ETjKWhWZgHca1LH1+f1h/b0Bcjyz5t8oXrVUwRPKwEBL3yGuIblNhoodXWLEls2wfq TAzmgCuTGa3xZwnaKpyHLvKETcZQu78BLLUFc1r++KbRKCRc6KWdshNxvXs1w6yCtDSI 45mA== X-Gm-Message-State: AOAM530hZl4w48oBXv4cO5a7kI8c5eIK+PGzcbuwcaUjNZiAkxNJsAjb fpNeJN0Y56pJDOf8PFdQaKqTH4QFvPuj8ubvm9zlqVvYZKDnf3j9pR7XuJFI6oEvgp3p6yUNpGF y+ZP29t29AV/n/bvdLeZjErLu X-Received: by 2002:a50:cb85:: with SMTP id k5mr32554927edi.170.1622623129843; Wed, 02 Jun 2021 01:38:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznNx1BKF2wb6aAOnoMMX1IU04QbC3N7r29/JqfnA7jMn5hjgExL0f5PSdJyUQIWvBLHfs6/g== X-Received: by 2002:a50:cb85:: with SMTP id k5mr32554918edi.170.1622623129709; Wed, 02 Jun 2021 01:38:49 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id cz14sm840407edb.84.2021.06.02.01.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 01:38:49 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 878F5180726; Wed, 2 Jun 2021 10:38:47 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Magnus Karlsson , Wang Hai Cc: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , "Karlsson, Magnus" , Jonathan Lemon , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Network Development , bpf , open list Subject: Re: [PATCH net-next] xsk: Return -EINVAL instead of -EBUSY after xsk_get_pool_from_qid() fails In-Reply-To: References: <20210602031001.18656-1-wanghai38@huawei.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 02 Jun 2021 10:38:47 +0200 Message-ID: <87a6o8bqzs.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Magnus Karlsson writes: > On Wed, Jun 2, 2021 at 6:02 AM Wang Hai wrote: >> >> xsk_get_pool_from_qid() fails not because the device's queues are busy, >> but because the queue_id exceeds the current number of queues. >> So when it fails, it is better to return -EINVAL instead of -EBUSY. >> >> Signed-off-by: Wang Hai >> --- >> net/xdp/xsk_buff_pool.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c >> index 8de01aaac4a0..30ece117117a 100644 >> --- a/net/xdp/xsk_buff_pool.c >> +++ b/net/xdp/xsk_buff_pool.c >> @@ -135,7 +135,7 @@ int xp_assign_dev(struct xsk_buff_pool *pool, >> return -EINVAL; >> >> if (xsk_get_pool_from_qid(netdev, queue_id)) >> - return -EBUSY; >> + return -EINVAL; > > I guess your intent here is to return -EINVAL only when the queue_id > is larger than the number of active queues. But this patch also > changes the return code when the queue id is already in use and in > that case we should continue to return -EBUSY. As this function is > used by a number of drivers, the easiest way to accomplish this is to > introduce a test for queue_id out of bounds before this if-statement > and return -EINVAL there. Isn't the return code ABI by now, though? -Toke