From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CB7C54E8E for ; Mon, 11 May 2020 01:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A01A9207FF for ; Mon, 11 May 2020 01:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729266AbgEKBaR (ORCPT ); Sun, 10 May 2020 21:30:17 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:6973 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728630AbgEKBaQ (ORCPT ); Sun, 10 May 2020 21:30:16 -0400 Date: 11 May 2020 10:30:15 +0900 X-IronPort-AV: E=Sophos;i="5.73,377,1583161200"; d="scan'208";a="46714492" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 11 May 2020 10:30:15 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 1536340083C3; Mon, 11 May 2020 10:30:15 +0900 (JST) Message-ID: <87a72f9s2g.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Yongbo Zhang Cc: broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Li Subject: Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer In-Reply-To: <20200508074753.10362-1-giraffesnn123@gmail.com> References: <20200508074753.10362-1-giraffesnn123@gmail.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yongbo Thank you for the patch > SSI BUSIF buffer is possible to overflow or underflow, especially in a > hypervisor environment. If there is no interrupt support, it will eventually > lead to errors in pcm data. > This patch adds overflow and underflow interrupt support for SSI BUSIF buffer. > > Cc: Kuninori Morimoto > Reported-by: Chen Li > Signed-off-by: Yongbo Zhang > Tested-by: Chen Li > --- (snip) > @@ -635,6 +713,19 @@ static int rsnd_ssi_irq(struct rsnd_mod *mod, > if (enable) > val = rsnd_ssi_is_dma_mode(mod) ? 0x0e000000 : 0x0f000000; > > + if (is_tdm || is_tdm_split) { > + switch (id) { > + case 0: > + case 1: > + case 2: > + case 3: > + case 4: > + case 9: > + val |= 0xff00; > + break; > + } > + } This is small things, but we like to have - val |= 0xff00; + val |= 0x0000ff00; Except above Acked-by: Kuninori Morimoto Thank you for your help !! Best regards --- Kuninori Morimoto