From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E062DC43381 for ; Mon, 25 Feb 2019 01:18:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF18020989 for ; Mon, 25 Feb 2019 01:18:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727916AbfBYBSI (ORCPT ); Sun, 24 Feb 2019 20:18:08 -0500 Received: from relmlor1.renesas.com ([210.160.252.171]:38655 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725991AbfBYBSH (ORCPT ); Sun, 24 Feb 2019 20:18:07 -0500 Date: 25 Feb 2019 10:18:06 +0900 X-IronPort-AV: E=Sophos;i="5.58,409,1544454000"; d="scan'208";a="8726679" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 25 Feb 2019 10:18:06 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 98C8E400A0F7; Mon, 25 Feb 2019 10:18:06 +0900 (JST) Message-ID: <87a7ik3cea.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Kuninori Morimoto Cc: , , , , , , , Jiada Wang Subject: Re: [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address In-Reply-To: <87bm303cie.wl-kuninori.morimoto.gx@renesas.com> References: <1550823803-32446-1-git-send-email-twischer@de.adit-jv.com> <87bm303cie.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiada, again > > Currently each SSI unit 's busif dma address is calculated by > > following calculation formulation: > > 0xec540000 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400 > > > > But according to user manual 41.1.4 Register Configuration > > ssi9 4/5/6/7 busif data register address > > (SSI9_4_BUSIF/SSI9_5_BUSIF/SSI9_6_BUSIF/SSI9_7_BUSIF) > > are out of this rule. > > > > This patch updates the calculation formulation to correct > > ssi9 4/5/6/7 busif data register address > > > > Fixes: commit 5e45a6fab3b9 ("ASoc: rsnd: dma: Calculate dma address with consider of BUSIF") > > Signed-off-by: Jiada Wang > > Signed-off-by: Timo Wischer > > --- > > We don't need below anymore by this patch ? > > --- dma.c ---- > /* > * FIXME > * > * We can't support SSI9-4/5/6/7, because its address is > * out of calculation rule > */ > if ((id == 9) && (busif >= 4)) > dev_err(dev, "This driver doesn't support SSI%d-%d, so far", > id, busif); Oops, next patch is removing this. Please ignore this mail.