From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932965AbdKGSrA (ORCPT ); Tue, 7 Nov 2017 13:47:00 -0500 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:52645 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932897AbdKGSq6 (ORCPT ); Tue, 7 Nov 2017 13:46:58 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 07 Nov 2017 19:46:55 +0100 X-ME-IP: 90.55.206.157 From: Robert Jarzmik To: Colin King Cc: Daniel Mack , Haojian Zhuang , Felipe Balbi , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] usb: gadget: pxa27x: Remove redundant assignment to is_short and dev References: <20171107143914.5748-1-colin.king@canonical.com> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 07 Nov 2017 19:46:53 +0100 In-Reply-To: <20171107143914.5748-1-colin.king@canonical.com> (Colin King's message of "Tue, 7 Nov 2017 14:39:14 +0000") Message-ID: <87a7zy7wpu.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King writes: > From: Colin Ian King > > Variable is_short is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed. Pointer dev is assigned a value that > is not read and it is updated a few statements later, this too is > redundant and can be removed. Cleans up clan warnings: > > drivers/usb/gadget/udc/pxa27x_udc.c:986:3: warning: Value stored > to 'is_short' is never read > drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored > to 'dev' is never read Acked-by: Robert Jarzmik Cheers. -- Robert