From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbdIVJGc (ORCPT ); Fri, 22 Sep 2017 05:06:32 -0400 Received: from mga02.intel.com ([134.134.136.20]:18790 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868AbdIVJGb (ORCPT ); Fri, 22 Sep 2017 05:06:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,427,1500966000"; d="scan'208";a="1017289987" From: Alexander Shishkin To: Greg KH Cc: Mathieu Poirier , Chunyan Zhang , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [GIT PULL 1/3] stm class: Fix a use-after-free In-Reply-To: <20170922082857.GA26322@kroah.com> References: <20170919154742.19696-1-alexander.shishkin@linux.intel.com> <20170919154742.19696-2-alexander.shishkin@linux.intel.com> <20170922082857.GA26322@kroah.com> User-Agent: Notmuch/0.23.7 (http://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Fri, 22 Sep 2017 12:06:27 +0300 Message-ID: <87a81nt84s.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH writes: > On Tue, Sep 19, 2017 at 06:47:40PM +0300, Alexander Shishkin wrote: >> For reasons unknown, the stm_source removal path uses device_destroy() >> to kill the underlying device object. Because device_destroy() uses >> devt to look for the device to destroy and the fact that stm_source >> devices don't have one (or all have the same one), it just picks the >> first device in the class, which may well be the wrong one. >> >> That is, loading stm_console and stm_heartbeat and then removing both >> will die in dereferencing a freed object. >> >> Since this should have been device_unregister() in the first place, >> use it instead of device_destroy(). >> >> Signed-off-by: Alexander Shishkin >> Fixes: 7bd1d4093c2 ("stm class: Introduce an abstraction for System Trace Module devices") >> Cc: stable@vger.kernel.org >> --- >> drivers/hwtracing/stm/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Ugh, I just applied these as patches, and didn't do the git pull, sorry > about that, my fault. No worries, I'm fine either way. > But really, patches for short series are really easy for me to do... Sure, that's one reason why I sent it like that, so you get to choose. Thanks, -- Alex