From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750940AbdAXWqA (ORCPT ); Tue, 24 Jan 2017 17:46:00 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:49994 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbdAXWp6 (ORCPT ); Tue, 24 Jan 2017 17:45:58 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: "Michael Kerrisk \(man-pages\)" Cc: "Serge E. Hallyn" , Linux API , lkml , "linux-fsdevel\@vger.kernel.org" , Andrey Vagin , James Bottomley , "W. Trevor King" , Alexander Viro References: <93e5c7f9-9dc1-6c93-ad20-0ba053d8bfef@gmail.com> Date: Wed, 25 Jan 2017 11:41:42 +1300 In-Reply-To: (Michael Kerrisk's message of "Wed, 25 Jan 2017 10:34:18 +1300") Message-ID: <87a8aggjx5.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1cW9qd-0001Ak-TP;;;mid=<87a8aggjx5.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=101.100.131.98;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18zbcWfen8ofU+oZrWmcQj3TG32a3SNKvU= X-SA-Exim-Connect-IP: 101.100.131.98 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 BAYES_40 BODY: Bayes spam probability is 20 to 40% * [score: 0.3902] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;"Michael Kerrisk \(man-pages\)" X-Spam-Relay-Country: X-Spam-Timing: total 162 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.2 (2.0%), b_tie_ro: 2.3 (1.4%), parse: 1.00 (0.6%), extract_message_metadata: 3.2 (1.9%), get_uri_detail_list: 1.09 (0.7%), tests_pri_-1000: 4.3 (2.7%), tests_pri_-950: 1.22 (0.8%), tests_pri_-900: 0.96 (0.6%), tests_pri_-400: 17 (10.7%), check_bayes: 16 (10.1%), b_tokenize: 5.0 (3.1%), b_tok_get_all: 6 (3.5%), b_comp_prob: 1.79 (1.1%), b_tok_touch_all: 1.99 (1.2%), b_finish: 0.61 (0.4%), tests_pri_0: 116 (71.9%), check_dkim_signature: 0.45 (0.3%), check_dkim_adsp: 2.6 (1.6%), tests_pri_500: 4.9 (3.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v2 0/2] Add further ioctl() operations for namespace discovery X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Michael Kerrisk (man-pages)" writes: > Hi Eric, > > Do you have any input for this small patch set? I've still to tweak a > comment as suggested by Trevor King, but otherwise I'd like to know if > this is good to go for the next merge window. Apologies I have been bogged down with other things. Basically the code looks fine, and now that I have caught up with things I will be happy to merge your for the next merge window. I do wonder if returning -EOVERFLOW may be more useful than running the overflow_uid when mapping fails. Also, now that I think about it. Please let's use (uid_t __user *) for the type of argp. I think that will be more maintainable in the long run. Easier to grep for etc. Neither of these things are big or would prevent me from merging your change just things that I think would be nice to have. Eric