From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754567AbcJEC0o convert rfc822-to-8bit (ORCPT ); Tue, 4 Oct 2016 22:26:44 -0400 Received: from ozlabs.org ([103.22.144.67]:53223 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753973AbcJEC0n (ORCPT ); Tue, 4 Oct 2016 22:26:43 -0400 From: Michael Ellerman To: Emilio =?utf-8?Q?L=C3=B3pez?= Cc: shuah@kernel.org, devel@driverdev.osuosl.org, gustavo.padovan@collabora.co.uk, riandrews@android.com, daniel.vetter@ffwll.ch, John.C.Harrison@Intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, ghackmann@google.com, robdclark@gmail.com, linux-kselftest@vger.kernel.org, maarten.lankhorst@linux.intel.com, daniels@collabora.com, arve@android.com, emil.l.velikov@gmail.com Subject: Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework In-Reply-To: References: <20160921211205.22657-1-emilio.lopez@collabora.co.uk> <20160921211205.22657-2-emilio.lopez@collabora.co.uk> <87fuos8e25.fsf@concordia.ellerman.id.au> <56f420ed-e985-2433-31fd-50515d8bcd1c@collabora.co.uk> <87ponq6kea.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 05 Oct 2016 12:00:07 +1100 Message-ID: <87a8ej4nl4.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Emilio López writes: > Hi, > > El 27/09/16 a las 01:23, Michael Ellerman escribió: >> Emilio López writes: >>> El 22/09/16 a las 06:43, Michael Ellerman escribió: >>>> Emilio López writes: >>>> >>>> Please don't include the *kernel* headers, they're really not meant to >>>> be used in userspace programs :) >>>> >>>>> +CFLAGS += -I../../../../usr/include/ >>>> >>>> That is the correct place to get them from. They'll have been put there >>>> by 'make headers_install'. >>> >>> My inspiration here has been tools/testing/selftests/memfd/Makefile, >>> which does it this way. If I only include the ones on usr then it >>> doesn't build, as there's no sync_file.h available, even after running >>> make headers_install. How am I supposed to use the ioctls from there? >> >> It looks like it's missing from include/uapi/linux/Kbuild, you need to >> add it to the list of exported headers: > > I tried that over the weekend and it worked, but I wondered if it was > the way to go. Thanks for the confirmation :) I've sent a patch for > that[0] now. Great thanks. > With that resolved, CFLAGS can just be > > CFLAGS += -O2 -g -std=gnu89 -pthread -Wall -Wextra > CFLAGS += -I../../../../usr/include/ LGTM. cheers