From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374AbcHNTaJ (ORCPT ); Sun, 14 Aug 2016 15:30:09 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:35397 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbcHNTaH (ORCPT ); Sun, 14 Aug 2016 15:30:07 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 14 Aug 2016 21:30:05 +0200 X-ME-IP: 109.222.82.242 From: Robert Jarzmik To: Hans Verkuil Cc: Mauro Carvalho Chehab , Guennadi Liakhovetski , Jiri Kosina , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device References: <1470684652-16295-1-git-send-email-robert.jarzmik@free.fr> <1470684652-16295-12-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 14 Aug 2016 21:30:04 +0200 Message-ID: <87a8gfrvwj.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > >> + pcdev->sensor = subdev; >> + pcdev->vdev.queue = &pcdev->vb2_vq; >> + pcdev->vdev.v4l2_dev = &pcdev->v4l2_dev; > > You're missing this line here: > > pcdev->vdev.ctrl_handler = subdev->ctrl_handler; > > This ensures that the sensor's controls are exposed to the video device node. Okay, I'm on it, for v4. >> + video_set_drvdata(&pcdev->vdev, pcdev); >> + >> + v4l2_disable_ioctl(vdev, VIDIOC_G_STD); >> + v4l2_disable_ioctl(vdev, VIDIOC_S_STD); > > Since you don't implement vidioc_g/s_std these two lines can be removed. Okay, for v4. Cheers. -- Robert