From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933579AbcFNEtc (ORCPT ); Tue, 14 Jun 2016 00:49:32 -0400 Received: from anholt.net ([50.246.234.109]:47138 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932320AbcFNEtb (ORCPT ); Tue, 14 Jun 2016 00:49:31 -0400 From: Eric Anholt To: Matthias Reichl , Vinod Koul , Stephen Warren , Lee Jones Cc: Martin Sperl , Clive Messer , dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dmaengine: bcm2835: Fix cyclic DMA period splitting In-Reply-To: <1465472504-10191-2-git-send-email-hias@horus.com> References: <1465472504-10191-1-git-send-email-hias@horus.com> <1465472504-10191-2-git-send-email-hias@horus.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 13 Jun 2016 21:49:26 -0700 Message-ID: <87a8iowf1l.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Matthias Reichl writes: > The code responsible for splitting periods into chunks that > can be handled by the DMA controller missed to update total_len, > the number of bytes processed in the current period, when there > are more chunks to follow. > > Therefore total_len was stuck at 0 and the code didn't work at all. > This resulted in a wrong control block layout and audio issues because > the cyclic DMA callback wasn't executing on period boundaries. > > Fix this by adding the missing total_len update. It looks like this issue has been around for a long time, and this fix is pretty dependent on the recent refactors. Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXX4zWAAoJELXWKTbR/J7oz5cP/3HX13Mr2f9QCi4gPei2NbHP /aVtWP4V6KKnF1mdPDvlGqDEkXWxIUN4iuodiKMen/Z0ka0D6WqXxw6hHMgUkCXW noUQcvSGRo+ab4XC52+tEsv1HuVd1/HxYpRu8sS4715pgyudBc5CtTunKj0PQPoJ R/Y6TmXpvgbrOOK55vqCrv3CW0DRZ9SL1/q767oUazBC49T94uY6haRpYHDz2dgV Elxvb1OgBIcBhtibbqm7Duz7vkx9A5jMVAyDaIJraWWPAT2dYzNZDyTTgmHrhgFd qazcfN3MXVXPNcJLT1ivgmDvLpn5c3w2BD0n5BO/uC4l8/HrRC1ZGvDDmOUv2sVr OHhf1fky8VDNZ1kw6e/vRvZjynmdQ0kfyatpN400WqidUoXcuhaiP11vS227tbbT zP9yMkAawiraTgD5wafZfDuXu+F1Eh2biVPmeueEbxtkB4ahaaUfWxzBJHECStP8 SnZPMUT3Zf+8fXyKreTmVL239B16h+KmJd6Cu/XNG5qJHptdIeuO0Q/5gmd9De6b vpJR8v+hQbUMiE2BxwbKwk71sXdaBviRPc7qG8Es1ikQhFOxWJwDgUyDawvJLyue FAouwccqpcvTU4FOPFYChKAhJ/aE9t7yMDmPX8HkwetlWwNKforMnhE8w639utyT PHr9go+XAIxNxddpn0vB =X9xS -----END PGP SIGNATURE----- --=-=-=--