From: Kalle Valo <kvalo@codeaurora.org>
To: Eliad Peller <eliad@wizery.com>
Cc: Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"open list\:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
Guy Mishol <guym@ti.com>,
Uri Mashiach <uri.mashiach@compulab.co.il>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Date: Fri, 15 Apr 2016 15:22:28 +0300 [thread overview]
Message-ID: <87a8kvqcxn.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAB3XZEfePJG7t6+TGYer_pcdqqaTfYugK0cARwhgLm9KRG1fmg@mail.gmail.com> (Eliad Peller's message of "Thu, 31 Mar 2016 11:59:39 +0300")
Eliad Peller <eliad@wizery.com> writes:
> On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches <joe@perches.com> wrote:
>> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote:
>>> Joe Perches <joe@perches.com> writes:
>>> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
>>> > > Joe Perches <joe@perches.com> writes:
>>> > > >
>>> > > > Using the normal kernel logging mechanisms makes this code
>>> > > > a bit more like other wireless drivers.
>>> > > Personally I don't see the point but I don't have any strong opinions. A
>>> > > bigger problem is that TI drivers are not really in active development
>>> > > and that's I'm not thrilled to take big patches like this for dormant
>>> > > drivers.
>>> > Not very dormant.
>>> >
>>> > 35 patches in the last year, most of them adding functionality.
>>> Oh, I didn't realise it had that many patches. But the driver is
>>> orphaned and doesn't have a maintainer so could I then have an ack from
>>> one of the active contributors that this ok?
>>
>> Fine by me.
>>
>> $ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/
>>
>> Kalle Valo <kvalo@codeaurora.org> (maintainer:NETWORKING DRIVERS (WIRELESS),commit_signer:27/35=77%)
>> Eliad Peller <eliad@wizery.com> (commit_signer:9/35=26%,authored:7/35=20%)
>> Guy Mishol <guym@ti.com> (commit_signer:6/35=17%,authored:5/35=14%)
>> Johannes Berg <johannes.berg@intel.com> (commit_signer:6/35=17%,authored:3/35=9%)
>> Uri Mashiach <uri.mashiach@compulab.co.il> (commit_signer:4/35=11%,authored:4/35=11%)
>>
>> For those people now added to the cc list,
>> here's the original patch thread:
>>
>> https://lkml.org/lkml/2016/3/7/1099
>
> I don't have a strong opinion here either.
> (I do like the trailing newline being added automatically, but that's
> hardly an issue...)
Ok, I didn't get any objections so I'm planning to this set. If someone
thinks this is a bad idea speak up now.
--
Kalle Valo
prev parent reply other threads:[~2016-04-15 12:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 0:19 Joe Perches
2016-03-08 0:19 ` [PATCH 1/5] ti: Convert wl1271_<level> logging macros to dev_<level> or pr_<level> Joe Perches
2016-04-26 9:06 ` Kalle Valo
2016-03-08 0:19 ` [PATCH 2/5] ti: wl1251: Convert wl1251_error to wiphy_err/pr_err Joe Perches
2016-03-08 0:19 ` [PATCH 3/5] ti: wl1251: Convert wl1251_warning to wiphy_warn Joe Perches
2016-03-08 0:19 ` [PATCH 4/5] ti: wl1251: Convert wl1251_notice to wiphy_info/pr_info Joe Perches
2016-03-08 0:19 ` [PATCH 5/5] ti: wl1251: Convert wl1251_info to wl1251_debug Joe Perches
2016-03-30 11:51 ` [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style Kalle Valo
2016-03-30 21:36 ` Joe Perches
2016-03-31 7:39 ` Kalle Valo
2016-03-31 8:07 ` Joe Perches
2016-03-31 8:59 ` Eliad Peller
2016-04-15 12:22 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8kvqcxn.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=eliad@wizery.com \
--cc=guym@ti.com \
--cc=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=uri.mashiach@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®