From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758796AbcDHSUn (ORCPT ); Fri, 8 Apr 2016 14:20:43 -0400 Received: from anholt.net ([50.246.234.109]:32834 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758757AbcDHSUl (ORCPT ); Fri, 8 Apr 2016 14:20:41 -0400 From: Eric Anholt To: Stephen Warren Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Thomas Gleixner , Jason Cooper , Marc Zyngier Subject: Re: [PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call In-Reply-To: <570497C7.10501@wwwdotorg.org> References: <1459827858-3871-1-git-send-email-eric@anholt.net> <1459827858-3871-5-git-send-email-eric@anholt.net> <570497C7.10501@wwwdotorg.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 08 Apr 2016 11:20:30 -0700 Message-ID: <87a8l40xox.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Stephen Warren writes: > On 04/04/2016 09:44 PM, Eric Anholt wrote: >> dsb() requires an argument on arm64, so we needed to add "sy". >> Instead, take this opportunity to switch to the same smp_wmb() call >> that gic uses for its IPIs. This is a less strong barrier than we >> were doing before (dmb(ishst) compared to dsb(sy)), but it seems to be >> the correct one. > > I assume all MMIO is part of the ish domain? > > If so, the series, > Acked-by: Stephen Warren I don't know if this barrier implies ordering all the way out to AXI on this HW, but I don't think that's a requirement of this function. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXB/ZuAAoJELXWKTbR/J7ozxAP+wcmgSdCib3alj8/3ajyzRd7 gxEtIeNJSJDKER7y6bHNObnHGf1Ck6xvHO2TXIPoO60mgQ9CqTczj9cSGfLfGQic IsmpAac0EfQhyIdWLHwWPVCfEdWsYvHH2SPBkB3cjNplX9pbFw8lfp1buWFVDkkg TOOzFwUQ9mTRrzg59ixIp+LMW04KyRjJ8Hwu19XqzhLOn7hyFbdFlAWSlqshrxlC fG+jMHzuhOeA+FZagR+E/7cQW6K3XSLd0H1HwEEVO8f9oqXc9+ppVhoZnV04NpPw 0Ilqo7EiuJzEOiEKtBZCPyplG+yWXvxg4RkF1+LDSlCRKpKimW8hGnkmV+KlRO4A 1yp54JPjIh7ElD9+YE8r/gPqwp6sE+qJdKJ8ntYeYnedrAIkLUMTG8BIQAQP9VF4 Y7FKxcxW49qEOrU29ScaeybQjWixeKbMGdfxSdPBanhIdZu7DSgfKH7p9FUZ5tGc NiKZOlKqvNng+W9IpipPV7kPA+VKsHeu1JYMggD5IUk3k2xjoQ4JwO6DdPzJWN82 WxAV8CgXEmlZesYBH7F6lpy+DoRXh8mTsCPreAsHQyZAWdDh36hNSA00be0LfDzj U7Dg+suPN+ko1P2d7fdjq25/wJpdY3QefbY+cDDM/0HCBDPvXT1SwfdiVSBxenX1 hhU53B+cNrZRPoR1H77W =zmkc -----END PGP SIGNATURE----- --=-=-=--