From: Felipe Balbi <balbi@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bin Liu <b-liu@ti.com>, Peter Chen <hzpeterchen@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Peter Chen <peter.chen@nxp.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: rework CONFIG_USB_COMMON logic
Date: Wed, 30 Mar 2016 16:56:25 +0300 [thread overview]
Message-ID: <87a8lghxx2.fsf@intel.com> (raw)
In-Reply-To: <4019862.J6BPYbmbYs@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]
Arnd Bergmann <arnd@arndb.de> writes:
> [ text/plain ]
> On Wednesday 30 March 2016 13:31:01 Felipe Balbi wrote:
>> Arnd Bergmann <arnd@arndb.de> writes:
>> > [ text/plain ]
>> > The phy-am335x driver selects 'USB_COMMON', but all other drivers
>> > use 'depends on' for that symbol, and it depends on USB || USB_GADGET
>> > itself, which causes a Kconfig warning:
>> >
>> > warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>> >
>> > As suggested by Felipe Balbi, this turns the logic around, and makes
>> > 'USB_COMMON' selected by everything else that needs it, so we can
>> > remove the dependencies.
>> >
>> > Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > Acked-by: Felipe Balbi <balbi@kernel.org>
>> > Reviewed-by: Peter Chen <peter.chen@nxp.com>
>> > ---
>> > I seem to have dropped the ball on this one after my initial submission
>> > when it wasn't clear who should merge the patch.
>> >
>> > Please apply to the USB or the USB gadget tree, whoever gets there
>> > first.
>>
>> seems like this is one of those "can wait for next merge window" right ?
>> I'll take it through my tree. No issues.
>
> Correct, it's not urgent at all, I just want it to disappear from
> my backlog of unapplied patches.
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=5412212bf636f75cba8a0e3637e666b279e7067a
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-03-30 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 16:45 Arnd Bergmann
2016-03-30 10:31 ` Felipe Balbi
2016-03-30 13:53 ` Arnd Bergmann
2016-03-30 13:56 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-03 22:35 Arnd Bergmann
2016-02-04 6:39 ` Peter Chen
2016-02-04 8:20 ` Arnd Bergmann
2016-02-04 11:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8lghxx2.fsf@intel.com \
--to=balbi@kernel.org \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=hzpeterchen@gmail.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome