From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752866AbcBOSkG (ORCPT ); Mon, 15 Feb 2016 13:40:06 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:54598 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752604AbcBOSkB (ORCPT ); Mon, 15 Feb 2016 13:40:01 -0500 From: Punit Agrawal To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Guenter Roeck , Jean Delvare , lm-sensors@lm-sensors.org Subject: Re: [PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor values References: <1455028377-12728-1-git-send-email-sudeep.holla@arm.com> Date: Mon, 15 Feb 2016 18:36:04 +0000 In-Reply-To: <1455028377-12728-1-git-send-email-sudeep.holla@arm.com> (Sudeep Holla's message of "Tue, 9 Feb 2016 14:32:56 +0000") Message-ID: <87a8n1akiz.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sudeep Holla writes: > SCPI specification version 1.1 extended the sensor from 32-bit to 64-bit > values in order to accommodate new sensor class with 64-bit requirements > > Since the SCPI driver sets the higher 32-bit for older protocol version > to zeros, there's no need to explicitly check the SCPI protocol version > and the backward compatibility is maintainted. > > Cc: Punit Agrawal Thanks for the update to the driver. Reviewed-by: Punit Agrawal > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_scpi.c | 8 +++++--- > drivers/hwmon/scpi-hwmon.c | 6 +++--- > include/linux/scpi_protocol.h | 2 +- > 3 files changed, 9 insertions(+), 7 deletions(-) > > Hi Guenter, > > Since I have couple of other fixes for SCPI driver, if you can provide > your ACKs to this couple of patches after your review, I can take all of > them together via ARM-SoC if that's fine with you. > > Regards, > Sudeep > [...]