From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbbIZUYN (ORCPT ); Sat, 26 Sep 2015 16:24:13 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:56524 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbbIZUYM (ORCPT ); Sat, 26 Sep 2015 16:24:12 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 26 Sep 2015 22:24:10 +0200 X-ME-IP: 109.222.127.209 From: Robert Jarzmik To: Brian Norris , Ezequiel Garcia Cc: David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal References: <1440961710-17347-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 26 Sep 2015 22:19:07 +0200 In-Reply-To: <1440961710-17347-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sun, 30 Aug 2015 21:08:30 +0200") Message-ID: <87a8s9exxg.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > After the conversion of pxa architecture to common clock framework, the > NAND clock can be disabled on driver exit. > > In this case, it happens that if the driver used the NAND and set the > DFI arbitration bit, the next access to a static memory controller area, > such as an ethernet card, will stall the system bus, and the core will > be stalled forever. > > This is especially true on pxa31x SoCs, where the NDCR was augmented > with a new bit to prevent this lockups by giving full ownership of the > DFI arbiter to the SMC, in change SCr#6. > > Fix this by clearing the DFI arbritration bit in driver exit. This > effectively prevents a lockup on zylonite when removing pxa3xx-nand > module, and using ethernet afterwards. > > Signed-off-by: Robert Jarzmik Hi Brian, Are you happy with this patch, and if so could you queue it please ? Cheers. -- Robert