From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753095AbbIMOYV (ORCPT ); Sun, 13 Sep 2015 10:24:21 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35842 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbbIMOYS (ORCPT ); Sun, 13 Sep 2015 10:24:18 -0400 From: Peter Korsgaard To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, mpm@selenic.com, kernel@stlinux.com Subject: Re: [PATCH 2/6] hwrng: core: Simplify RNG switching from sysfs References: <1442002110-28733-1-git-send-email-lee.jones@linaro.org> <1442002110-28733-3-git-send-email-lee.jones@linaro.org> Date: Sun, 13 Sep 2015 16:24:13 +0200 In-Reply-To: <1442002110-28733-3-git-send-email-lee.jones@linaro.org> (Lee Jones's message of "Fri, 11 Sep 2015 21:08:26 +0100") Message-ID: <87a8sq4ctu.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Lee" == Lee Jones writes: > If we attempt to use sysfs to change the current RNG in the usual > way i.e. issuing something like: > `echo 8a8a000.rng > /sys/devices/virtual/misc/hw_random/rng_current` > ... it will fail because the code doesn't currently take the '\n' > into consideration. Well, now it does. > Signed-off-by: Lee Jones > --- > drivers/char/hw_random/core.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c > index da8faf7..14dc984 100644 > --- a/drivers/char/hw_random/core.c > +++ b/drivers/char/hw_random/core.c > @@ -316,6 +316,7 @@ static ssize_t hwrng_attr_current_store(struct device *dev, > const char *buf, size_t len) > { > int err; > + int snip = 0; > struct hwrng *rng; > err = mutex_lock_interruptible(&rng_mutex); > @@ -323,7 +324,11 @@ static ssize_t hwrng_attr_current_store(struct device *dev, > return -ERESTARTSYS; > err = -ENODEV; > list_for_each_entry(rng, &rng_list, list) { > - if (strcmp(rng->name, buf) == 0) { > + > + if (buf[len-1] == '\n') > + snip = 1; /* Snip one character */ > + How about using sysfs_streq() instead, which is what is done elsewhere? -- Bye, Peter Korsgaard