mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
Date: Fri, 22 Aug 2014 17:21:12 +0200	[thread overview]
Message-ID: <87a96wsg7r.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <20140822144848.GF22707@saruman.home> (Felipe Balbi's message of "Fri, 22 Aug 2014 09:48:48 -0500")

Felipe Balbi <balbi@ti.com> writes:

> On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
>> Clearly this was meant to be an include guard, but a trailing
>> underscore was missing. It has been this way since the file was
>> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
>> 
>
> right here you need to have:
>
> Fixes: 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver")
> Cc: <stable@vger.kernel.org>

Really? I can't see that it satisfies the
Documentation/stable_kernel_rules.txt. There's no chance of build error, since the
file is only included directly from a single .c file. As you can see on
LKML I've sent a few handfuls of similar patches all over the tree; IMHO
none of them qualify for stable.

If you insist, I'll add the Fixes and Cc tags.

Thanks,
Rasmus

  reply	other threads:[~2014-08-22 15:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 12:59 [PATCH] " Rasmus Villemoes
2014-08-22 14:06 ` Felipe Balbi
2014-08-22 14:44   ` [PATCH v2] " Rasmus Villemoes
2014-08-22 14:48     ` Felipe Balbi
2014-08-22 15:21       ` Rasmus Villemoes [this message]
2014-08-22 15:58         ` Felipe Balbi
2014-08-25  8:30           ` [PATCH v3] " Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a96wsg7r.fsf@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®