mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: George Cherian <george.cherian@ti.com>
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	n.a.balandin@gmail.com
Subject: Re: [PATCH v3 0/3] cleanup of gpio_pcf857x.c
Date: Sun, 01 Sep 2013 23:55:00 -0700 (PDT)	[thread overview]
Message-ID: <87a9jvsofz.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <1378089004-14478-1-git-send-email-george.cherian@ti.com>


Hi

Sorry for my many response.

> This patch series
>         - removes the irq_demux_work
>         - Uses devm_request_threaded_irq
>         - Call the user handler iff gpio_to_irq is done.
> 
> v1 --> v2
>         Split v1 to 3 patches
> v2 --> v3
> 	Remove the unnecessary dts patches.
> 
> 
> George Cherian (3):
>   gpio: pcf857x: change to devm_request_threaded_irq
>   gpio: pcf857x: remove the irq_demux_work
>   gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done
> 
>  drivers/gpio/gpio-pcf857x.c | 51 +++++++++++++++++++++++----------------------
>  1 file changed, 26 insertions(+), 25 deletions(-)

Basically, I have no objection about these patches,
but I have 2 opinions
 - I guess we can merge #1 and #2 patches ?
   ("as is" is very OK for me though)
 - we don't need gpio->irq any more ?
   (additional patch is very OK for me)

Best regards
---
Kuninori Morimoto

  parent reply	other threads:[~2013-09-02  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02  2:30 George Cherian
2013-09-02  2:30 ` [PATCH v3 1/3] gpio: pcf857x: change to devm_request_threaded_irq George Cherian
2013-09-02  2:30 ` [PATCH v3 2/3] gpio: pcf857x: remove the irq_demux_work George Cherian
2013-09-02  2:30 ` [PATCH v3 3/3] gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done George Cherian
2013-09-02  6:55 ` Kuninori Morimoto [this message]
2013-09-02  7:20   ` [PATCH v3 0/3] cleanup of gpio_pcf857x.c George Cherian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9jvsofz.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=george.cherian@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=n.a.balandin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®