mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@CS.UCLA.EDU>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Matthew Wilcox <matthew@wil.cx>, Denis Cheng <crquan@gmail.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: diffutils: C labels misdetected as functions
Date: Sun, 22 Jul 2007 11:38:33 -0700	[thread overview]
Message-ID: <87abtogu6u.fsf@penguin.cs.ucla.edu> (raw)
In-Reply-To: <46A25BE0.7000104@simon.arlott.org.uk> (Simon Arlott's message of "Sat\, 21 Jul 2007 20\:17\:52 +0100")

Simon Arlott <simon@fire.lp0.eu> writes:

> The patch below stops diffutils treating C labels starting in column 1 as function names.

That patch alone wouldn't suffice, since -p is documented as implying
-F '^[[:alpha:]$_]'.  If the behavior changes, we'd also have to
change the documentation to match.

I'm not sure the change is a good idea.  It would complicate the
documentation and therefore the user interface, without that much
benefit.  And it wouldn't suffice in general, since it would still
mishandle labels followed by comments or by white space.

Also, for long C functions some people might rather see a top-level
(unindented) label highlighted than the function name highlighted, so
they might prefer the current behavior.

Anyway, to work around your problem without changing "diff", you can
use "diff -u -F '^[[:alpha:]$_](|.*[^:])$'" instead of "diff -u -p".
Or you can put a single space before the labels in question: they'll
still stand out plenty.

  reply	other threads:[~2007-07-22 18:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15  8:52 [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Denis Cheng
2007-07-15  8:52 ` [PATCH 2/2] add static delaration and init_module fixes Denis Cheng
2007-07-15  9:20 ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Christoph Hellwig
2007-07-15  9:53 ` Simon Arlott
2007-07-20 17:07   ` Matthew Wilcox
2007-07-20 17:36     ` Simon Arlott
2007-07-20 18:00       ` Matthew Wilcox
2007-07-21  6:11         ` Simon Arlott
2007-07-21 13:47           ` rae l
2007-07-21 13:52           ` Matthew Wilcox
2007-07-21 19:17             ` diffutils: C labels misdetected as functions (Was: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle) Simon Arlott
2007-07-22 18:38               ` Paul Eggert [this message]
2007-07-22 19:16                 ` diffutils: C labels misdetected as functions Simon Arlott
2007-07-22 21:30                   ` Junio C Hamano
2007-07-21  6:12         ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Simon Arlott
2007-07-20 20:50     ` Oleg Verych
2007-07-20 20:54       ` Matthew Wilcox
2007-07-21  4:32         ` Fixing lables after GNU indent (Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle) Oleg Verych
2007-07-21 16:17     ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Jan Engelhardt
2007-07-20 17:33   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87abtogu6u.fsf@penguin.cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=crquan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®