From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDA8431B110 for ; Wed, 24 Dec 2025 10:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573990; cv=none; b=E0S/sh67Vj/d7ndL1F5d8n49/fGYTC9jBYtp0wBtjUZGondJpFvBJhZc+qwAFaUeURrTLzz+DqaNXnUbMyyWFCMWvXD3dAAMRijHjpSQVHHQA58moGqps047ykGVVfd2o1YyWA/chBUWRE0ioUcsetLoi/W+ohrumjy11eJEIyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766573990; c=relaxed/simple; bh=rVelJD6U08k2g5EbxP79rz96OkNIYvjTufWPCeoLZbI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O5plpqwb4EomSCBMg8S17Mj7sIKiIKCXvjZNCGl1vaJpKc7OLvj23hOxFyr0uZygxqCQg5vc8v+bO3KMjHERwgYpTLcMWVewTTKHLpgiJ8MlfT2xXrIo4zm42gaIqFZmgvNF+EbaY8gHd5hHmR9gHpwcPZoxsQOHw8MrKBJNPXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kSFXgeTQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OYtLwVz8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kSFXgeTQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OYtLwVz8" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO6qfMN686440 for ; Wed, 24 Dec 2025 10:59:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 65ij+2/DAmNHoc4dyJwup6v//8+Tuz1DKXtAGu3ATBE=; b=kSFXgeTQ88GSv3mU uqASodlori7Mlj0Gh8UPHbtfBnLUaWzzsUj91N5dWGbQ6YJ7Uil5cAXrw1KnjlsT DgtrxJoSPgRIj2wTLE05pnRxntxhqcKEoNYGLgAej/ICxb6g4G7xwVfTrZQxMQ38 G5+4KESX0bR7y8TX+CPMaGA1l8orbveilfi3X0ir8hT+MNbiF7GyoNRUy1sXAP56 U8X9YeyPWB7KHD0ATIzIoOn18vi46XdXbDqX+3wXyYNzX1MNTB6vAGQOTF3VtCQr Zq/uEGkp0ZjKnTgwx7GqmHY5yTWuS16BvWvTsXRAW8qRkmOImaGYLQsHpYW4fvVL oa5Ajg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7yvq2djc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 10:59:48 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-bddf9ce4935so5495771a12.1 for ; Wed, 24 Dec 2025 02:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766573987; x=1767178787; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=65ij+2/DAmNHoc4dyJwup6v//8+Tuz1DKXtAGu3ATBE=; b=OYtLwVz8xPpNRfp6Dnk8Br8b/ammnKAHcgtcfgGuXxaxymKcOwdz/K3yekZcGXRUih /ny5KSGmqbpypY2o7+IwBwOUfgRyTtBcFNKD+9gdwu52+X8bfH2xb9/3gkROg2etySsS Hjy0x+L9BohhVkrZoIskBFdcIg1BPGUQRDtnIXtB5BOkLYyW0qb7TTWnyrQHBqGK0xWY 1dRyzum8PxGsAGows0PVtEcElUiAcToCr4iEEYqN7qkibUUBUzBwEVLMvC3PKD6ZhesJ nXrxvpYVJwTBeoRtErlhNq3CLJt9lkVIjXmIsiYENyK1t+eKXGhfCqQJm1jLOxIypDj2 RkoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766573987; x=1767178787; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=65ij+2/DAmNHoc4dyJwup6v//8+Tuz1DKXtAGu3ATBE=; b=NQPiF5IDl4KcWoCKuZZfGYCw2xBR/qmZ7NF1n792cOpCRssmF+/FqCry191XfanZ+o rn+hdgIl7NnWsBovmnByylY+ytrM6kjn+4c08FI5j5BYs/iQjOHSkXzBJ4yaAF5nboMf JqfOyYM1DV1GC+goFgRE5CWURvSVyeQp3LVn+hUKKAZTnFA06MXnWEIThOGpjigrPjZN 8Y7ivD+/zaK9uwSp+seUCwtYqNwk7WrLkLuDE0Wsy+TC+KZrxDVm/7BAy4TzNa5JzGY3 WAk+iK5G6ajIp5z3q+FRq6zYzggSx/OF8TehO+t1xyE7s4DpgPyiaMfSAmPmAMN8HsmD GzhQ== X-Forwarded-Encrypted: i=1; AJvYcCW9hY8RsT5IXQ4QG/eK7RGo0Ha8D9A8Vy6jbxa+IewrD7rqbe5bjMlD9EOD2eCFu2uw/G7DPK6dcjMrLr4=@vger.kernel.org X-Gm-Message-State: AOJu0YxzUQfolxEddetfUXh+Rwquf6Ttw9mz3zxPFXhKE6nl9bN2+sCX 3qBT8H4/0X8pIVVGL6JyJ6tgXtuaXQ0lb6N0Tf48+cAsm3thk094D9LejgBlR3V8916ldHwAlcd 8BWnOJuTAjAvksXe3M6MMfZwvPRy1A1BQgBrVCh9ut4Xq0Rb9ydxZmMW2gdWn8v7PS3w= X-Gm-Gg: AY/fxX5nKLWgKAGdJr49FJWSyj564JwMWGkKOoGowM4U1F9lGJo60b1XCWIW6zWro9Z +zd0AbCSScyP773immwhYXbYdgqHn7Lc3sbfyRJeMv9zKwkVBg3axR9FRqt0Nw7QIGpTzK6cmH3 HFw8+o6f3YZS8nAlpQeZtMW2uMaSp2JGgkd06edR3+iup5hEIIAUVTG2f9lL/oC0Zw7ZHBn7JDh tPRNyt6BvX6En0n3s2cti4qjOnYvC2oLaaTNNT9KKmj4aiWwyD2pLkgjwzhCoHz8AzkZJwLJn/v Eu2BzK7bKNv7Spa1bMhYQWiCLtRVvEDD+8j5NbCe7uvLaGKk1GC7WGuvsmPwml82DTxAZx7Nsj7 2iYjxjmLO0cp9DzZ2lWaXQBGZQRc4pu5hRmbi X-Received: by 2002:a05:6a20:e290:b0:35f:6e12:184c with SMTP id adf61e73a8af0-376a9ace741mr16490469637.60.1766573987356; Wed, 24 Dec 2025 02:59:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDxjHcmbAfU0vMSZnnELdYkr52FpZ+BCX/CkrCd0ClqFv8mPu7xlW3LaO3oV2R81ZNpYlPOg== X-Received: by 2002:a05:6a20:e290:b0:35f:6e12:184c with SMTP id adf61e73a8af0-376a9ace741mr16490450637.60.1766573986843; Wed, 24 Dec 2025 02:59:46 -0800 (PST) Received: from [192.168.1.5] ([27.57.93.98]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34eacbca905sm5971094a91.5.2025.12.24.02.59.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 02:59:46 -0800 (PST) Message-ID: <87b300a0-7ff6-4506-a27a-7a30e77c2bf6@oss.qualcomm.com> Date: Wed, 24 Dec 2025 16:29:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on qcs8300 To: Dmitry Baryshkov Cc: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Raviteja Laggyshetty , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20251128150106.13849-1-odelu.kukatla@oss.qualcomm.com> <20251128150106.13849-2-odelu.kukatla@oss.qualcomm.com> Content-Language: en-US From: Odelu Kukatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: R68RCI5K90g_ZXHVddYJMMMFS9In4lmv X-Authority-Analysis: v=2.4 cv=abZsXBot c=1 sm=1 tr=0 ts=694bc7a4 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=luqpl2TCSyK2LuNNAmtdDg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=izIGmOzjKg6u1_hBuywA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: R68RCI5K90g_ZXHVddYJMMMFS9In4lmv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA5NCBTYWx0ZWRfX4c4OUrUZpLi5 917DevJIwsP505K8aE4bWrSn5RKPZSUbKhWVwdyxxEY7SJp/Am6SWzXENfY6HWJrvgczPxxFJSt XmU7R6s9X/priUC1kbF6KvwHx8aK6jgqsHAndcOK/qDNRgDq+HUA739JWJld9QtoWuq2WvZBScQ wsUOHFecJjpIrjdejIGigUMNwHnulpQL4HXE1uV1cUJ+xpnN2SBVIEgEQwvpGFxzEmtkvIi0FCu yRbqHzLV6dVVefuXTFTERxxCmkHMe1/lMwOgOPdS32ZR+tm5oDRydmEx+G7UHyJ7Pd9IkloUyBK 3MLDoi9Eyfa0xvf3v4D1TH26kMW9OnYPFzuKeCpwQqQJyrS+t2edqCr8l3s4WC+d8kjDpvjJBrC xWlu6hteXq5Ugxq4HiL4ZsfXLSu1x8+fpiZEnQstwWzMk+dQZqLn/n6HRaDnE+7N8Zng8a25rl2 /bPWPa9c2YI5ifaoOqA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240094 On 12/24/2025 1:25 AM, Dmitry Baryshkov wrote: > On Fri, Nov 28, 2025 at 08:31:04PM +0530, Odelu Kukatla wrote: >> Add 'clocks' property to enable QoS configuration. This property >> enables the necessary clocks for QoS configuration. >> >> QoS configuration is essential for ensuring that latency sensitive >> components such as CPUs and multimedia engines receive prioritized >> access to memory and interconnect resources. This helps to manage >> bandwidth and latency across subsystems, improving system responsiveness >> and performance in concurrent workloads. >> >> Both 'reg' and 'clocks' properties are optional. If either is missing, >> QoS configuration will be skipped. This behavior is controlled by the >> 'qos_requires_clocks' flag in the driver, which ensures that QoS >> configuration is bypassed when required clocks are not defined. >> >> Signed-off-by: Odelu Kukatla >> --- >> .../interconnect/qcom,qcs8300-rpmh.yaml | 53 ++++++++++++++++--- >> 1 file changed, 47 insertions(+), 6 deletions(-) > > As a generic feedback for Qualcomm interconnect drivers (please pass it > through the team): > > Please ensure that QoS-related clocks are defined in the first driver > submission. DT bindings should describe the hardware and it's not that > the hardware has changed between the time the first patches were > submitted and this patchset. > > I see a typical pattern that QoS support is being submitted several > months later. Why is it so? Why can't QoS be a part of the _same_ > patchset? > Hi Dmitry, Thanks for feedback. we are ensuring that QoS-related clocks are defined in the first driver submission like recently for Glymur/Kaanapali, there were part of first driver submission. QCS8300 and QCS615 are the only chip-sets, we are sending QoS patches separately. Thanks, Odelu