From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com,
yashsri421@gmail.com
Subject: Re: [PATCH v5] checkpatch: improve email parsing
Date: Sun, 08 Nov 2020 03:36:53 -0800 [thread overview]
Message-ID: <87be917b79ca49d71366f553795da0cc81875c24.camel@perches.com> (raw)
In-Reply-To: <20201108100632.75340-1-dwaipayanray1@gmail.com>
On Sun, 2020-11-08 at 15:36 +0530, Dwaipayan Ray wrote:
> checkpatch doesn't report warnings for many common mistakes
> in emails. Some of which are trailing commas and incorrect
> use of email comments.
(just in case link to parent emailed patch for Andrew)
https://lore.kernel.org/lkml/20201108100632.75340-1-dwaipayanray1@gmail.com/T/#u
Thanks Dwaipayan.
Acked-by: Joe Perches <joe@perches.com>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> ---
You should start to add changelog blocks to these
versioned patches so it's easier to look for what
changed between versions.
here...
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
etc...
prev parent reply other threads:[~2020-11-08 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 10:06 Dwaipayan Ray
2020-11-08 11:36 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87be917b79ca49d71366f553795da0cc81875c24.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®