Re: [PATCH v2] ALSA: hda/realtek: Add mute and mic-mute LEDs for HP ENVY 16 (103c:8be5)

[Takashi Iwai <tiwai@suse.de>]

On Wed, 21 Oct 2026 03:22:05 +0200,
DragonicRage13 wrote:
> 
> The HP ENVY Laptop 16-h1xxx (PCI SSID 103c:8be5) uses an ALC245 codec
> with CS35L41 I2C speaker amplifiers. No LED fixup is applied for this
> subsystem ID, so the speaker mute LED and the microphone mute LED are
> never driven and do not follow their keys.
> 
> Add a fixup that calls the existing ALC245 mute LED COEF helper and the
> GPIO mic-mute LED helper directly, then chains to the CS35L41 I2C
> amplifier setup so the speakers keep working. Use it for 103c:8be5.
> 
> Tested on an HP ENVY Laptop 16-h1xxx running kernel 7.2.11: the
> hda::mute and hda::micmute LEDs appear and follow their keys, and the
> speaker amplifiers still bind (CS35L41 Bound in dmesg). The mic LED
> GPIO pin and polarity are not verified on other hardware.
> 
> Assisted-by: Claude:claude-haiku-5-5
> Signed-off-by: DragonicRage13 <ajaneshlal3@gmail.com>

Please use a real name (or a known identity) for Signed-off-by tag
(and the corresponding From tag), as Signed-off-by is a legal
requirement.

Also, since you're replacing the existing quirk, it's better to point
to the commit that introduced the quirk via Fixes tag.

Last but not least, the patch doesn't seem applied cleanly to the
latest sound.git tree.  Please rebase.

Could you resubmit with those corrections?


thanks,

Takashi