From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E037046C84D for ; Tue, 4 Aug 2026 10:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785838047; cv=none; b=YZe0K/4VQSS79/oSoCedTSORnri2NO5O6Tqo+U9oC2TlKT/uU/S3hWOxdXztiBbQ/U7Ima0pgurLjU+uhjN3XpGdO5Ntv8XV2gXumgdDOVyVlcIB6hrN1snIuK73L217Wp7fdQpCo6UZQWWty50aWOhMNEiH8BciDUSC4XqDvSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785838047; c=relaxed/simple; bh=jepb+VUTDpbcYOcoiP3c8KCXVj2f5l9bEEJUCWbsoek=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=KaGEPTuDvXhdaj+pUuPC6smDRS04c8mYJNRAUvq+wBwjaKTEcNgOnGcjcKQK7kbK9fJk2ipCf8nwe7k4vru7zxCGuNMCTzWHYl1K1oxuC9xiHY6bj+CbauGw1PSQ0P2yfDeu/Invhjw/80SKfsC91lh2GRAIBzlZZz6awBdjzKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=NgUpmUg7; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="NgUpmUg7" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6a051b73866so7071572a12.0 for ; Tue, 04 Aug 2026 03:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1785838044; x=1786442844; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jepb+VUTDpbcYOcoiP3c8KCXVj2f5l9bEEJUCWbsoek=; b=NgUpmUg7cQii/IkFbGxBuBK00C8eBks2U+xWy0LE9cz//yNS9Zz/F280DcPWxnm/ds 75ubtCxGsi8bohJvB/I+V4vYGsOI/qNd29uEiNj0G5vsWXFTYhcyZb8zSepxNGxGLTwS k1L18HbNKW72YJeOu5FPXDyn0f3M6K5rgdq5QnxPJrHBdt82WgNi+xxUZUQa2cLWxzC0 zVg+psjfgLhJFCVnefQF7Px6r/JxnxQ+z9x7R7Aht0Wg6aeMsnX1X8ZBnWtRHgDnZ9yy NDkCqFysjUJzedLAYsFn24GKqPnwc+auWtmMsQ+2r6LCH/aHiRVw92CGEB5URnD9brhG jgAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785838044; x=1786442844; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=jepb+VUTDpbcYOcoiP3c8KCXVj2f5l9bEEJUCWbsoek=; b=ZftzhzcuyoIAJc/2kT5H/Y4gRUTCws4QiNK6JzuQSU7HK1hW56/MS0OW0DDKmEtd9m 6EYBt1aOp7HViAe3aTGJPBPJo3/S7URfJCq40Ur89/7ETLtDIT6Veush/PzvGjuRIp0A oEusmqLyOZyqvZSEJMZDqCj3YnbW7kgAYIp/6Ks5f4soSqVpTzaQPpLf2Vl1nnp6Q04C sSNffUCSssg5Sl4RCfV2JkS71oQG0QIPdmuvcX3VLaX98Oau/0v5VRJa7bp9HLpFmo8c mLA/hMtwUIJH6V2RDtH6DVw6XSxQnVu4+UQFFG1PpO0RpMRA4nzLksWrRrdlQgEoAb1n DxZA== X-Forwarded-Encrypted: i=1; AHgh+Rq+L/cApnZEYs2NIe/jwWxzNEq1q2Vl6yj378pnljI8f7jbEe25W3uzgtY1RQM68kstd9p45J5iPgYRmC4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi8cnj6NDE0ik4yURxIsIDp9ic2bfmwwVyGS1X0D48EXjQc2kj 9qvMYwFgPnMtcmqN/x8xsYJw9GmWONH8pAzkXue/tXzF7iZD6zn5QDhxgm05ASMSDgw= X-Gm-Gg: AR+sD10++DYzjnlZBvaDGmHk7WX/dKEH4viMQv2b8u39nTSKel9o6YI7vrhG4YP7Ulg Msozek83QMmACXN525LjjVlXrtl0XfoYkj2N8zPFQ8aFOrkoon/ODU9BLO7bJiFPgqs25Ido962 kh/j87KX9dHE9OP+0ivj6oYvopvCSa/D72Mhs15dLxgML5fK46jvRo2uvXkIPoROLRiED6xX1O1 XWCSGQWysY5rf6mQXEPTHAUok8oNt0MJ7uhMZk5vHX94SvZLky7Un/xi6nyZTpINgyd4RjNyiXG /PTVZk50UmFIlcFjNc+yPJdXtBDJJpRp9z5ShbypahcZxYRYINnEoCRL5CoBJuA9Uw1DQ2I7/X5 kiYhNqwNKiCRIpugjl3RWkjsyYOqDLPeuuqeRbETbcpJ2nEPojkIyzmKIpT4JGWr9V6GQtmo8Ci y2ceJ3fNyzl4t8lNHIpy1N2T4JYvNwIq+Y8ok2FVyCwWDGhOxc38N9hmgVbqZ/XGY= X-Received: by 2002:a05:6402:24c7:b0:698:428e:9177 with SMTP id 4fb4d7f45d1cf-6a0a7c899c3mr9512823a12.11.1785838044186; Tue, 04 Aug 2026 03:07:24 -0700 (PDT) Received: from cloudflare.com ([104.28.21.182]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a09c5a09acsm6317456a12.4.2026.08.04.03.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 03:07:22 -0700 (PDT) From: Jakub Sitnicki To: Michal Luczaj Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , John Fastabend , Stanislav Fomichev , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , Jiayuan Chen , Joe Stringer , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf v2 1/2] bpf: Extract shared reqsk-to-listener upgrade In-Reply-To: <20260803-sockmap-lookup-tcp-leak-v2-1-306e025bfe66@rbox.co> (Michal Luczaj's message of "Mon, 03 Aug 2026 11:00:42 +0200") References: <20260803-sockmap-lookup-tcp-leak-v2-0-306e025bfe66@rbox.co> <20260803-sockmap-lookup-tcp-leak-v2-1-306e025bfe66@rbox.co> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Tue, 04 Aug 2026 12:07:21 +0200 Message-ID: <87bjbiyzae.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Aug 03, 2026 at 11:00 AM +02, Michal Luczaj wrote: > __bpf_sk_lookup() and bpf_sk_lookup() duplicate the same sk_to_full_sk() > reqsk-to-listener upgrade. Extract it into a helper. > > Leave the currently unreachable WARN_ONCE as a defensive assert. > > No functional change. > > Signed-off-by: Michal Luczaj > Reviewed-by: Emil Tsalapatis > --- Reviewed-by: Jakub Sitnicki