From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3425E3126DF for ; Mon, 18 May 2026 10:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100667; cv=none; b=ZlKl8SJJbAtg3zQ05MtVE0k93K7Zk4ofTNF9jKg/miGfExkb3A0KKZyV2DW5YVtbyWhnjhhanvFq24N3FttW2+sIYFB9of1Lx9SmtNLYh5Mp/9aNFI0s9E/N2zKFUKGQ+B0g+ou0C5ZmdkV0iO950PMbtRYOXCrwof2U7qgZi/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100667; c=relaxed/simple; bh=Lgl9dFvsnOiJKf30B8jN2dwhrj7KLgbwg1xS+Fz/uso=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cv3dzmvcL4DqTjVdTvPvV7kRX/untXLClwwG3gYsWaa6pPlvE8kgXnlawbNCoFusnfvJqlZeIrQsdN95Dw5wT+yYXYy0ujz8nJFDTnrIeQBWu5RSamhmoiByP3ZLRKtFXLHMiyCmo84lztKHfBZMsCL9qjdq5O0SLn5ip+m5mZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pp1bykBt; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mAyQ2PVZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pp1bykBt"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mAyQ2PVZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779100650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j8DhTEQbisiNb0DazV/8Ac1m1lv8eoNvuThrrZbbnYc=; b=Pp1bykBt7DFM0If00uRnK6ouGZSdwT8Fs8ZFc/8Z0aKNPCfMZmJaciYfrE7tJiPAioJgzn NnlYZC3keiKlncBViacUF6S960/ZdBxKRd2YdXJHtB6ZZaImW11EdFr5ctD3yWKg8isJ8q o7XBhYrPcVEiOm+xOb39eGCqJkKlx+0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-T_dB-Uw7NYanKMB00j8UHQ-1; Mon, 18 May 2026 06:37:28 -0400 X-MC-Unique: T_dB-Uw7NYanKMB00j8UHQ-1 X-Mimecast-MFC-AGG-ID: T_dB-Uw7NYanKMB00j8UHQ_1779100648 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-44dad1b938fso1255003f8f.1 for ; Mon, 18 May 2026 03:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779100648; x=1779705448; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=j8DhTEQbisiNb0DazV/8Ac1m1lv8eoNvuThrrZbbnYc=; b=mAyQ2PVZYL6ZriIeIQUyVfQCWMbOBMj8YDnMgU23iJj6pt48IKwJfy7z6CwCOTYVkO voZyr0dlhLRLM6I5XMy34CFPkYJ6Dbk5nwtt5OJmnn5IWvzC7asEcibe+pEa4V3LGGzv 4HVhqPkwTFw2xzyjK2HnUr6qzoyUo0RqKdvjIqJjfT3kcq9G7nHzHADs4JWSWZqBF4mn 0znBzOeEET6ountYQV0KHR9G5jRT646eECB/jPPz/IxF5acMi5KVWZMDBLp5x+A+5q3q 0NR4OJhgKtgpqPNQ7AIyBvTlrAm/BowCjekOKaErKcCa7of1k8IuOXrUQY4bTJcXp+B5 5GVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779100648; x=1779705448; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j8DhTEQbisiNb0DazV/8Ac1m1lv8eoNvuThrrZbbnYc=; b=jaRhIsaOpxM/5fDIKK59EAJQCSEkq7cXQcB9K69G7czXGsVliZLKkgN1pcR4Azi0tH yv69RYUfcR65QFJ8IiwrxatN/QKMa4sS5J7TgCmB6DWfmQcWIe89Ej8MZ3PeQ3jILRog s3KLYJ+/dsMd8kUQF0Kd5KirHlgjUP+Km1DaeoKEYq1cSbA9m74fkJpgiVLqGHh/beij lA71ru5hGwFHtwE8EOS0m2gudJtORSihFWmvdGcHKSLH0DQh0VuZa1hhKUBKfKznUSjF ouD8XkWVy2F+CTcBOdvGUfBRe7YdJck3JegTEoel37kXSmoLcVlHz/Eg9A8yw+aii0fs sbxg== X-Forwarded-Encrypted: i=1; AFNElJ+EWy6BHwSLUKQJGJdR7KRsRnNy68/XRKLS+uJ/aitLfNKcnUyUPcno0aq5g1nganV6PnqUzad4XaGr4dU=@vger.kernel.org X-Gm-Message-State: AOJu0YxRUZuBlfNM8wzGVpqO2MEcfaLDoieJOmQ6pAn4nIsZ4i2AkHng EtETWwUOINaZ/SG+Z3Y1hEkdOxqhO6CV/5WPbwLWvuxI1zPQnL+88Nc35mQ873z3ZrzUbko7h6D qHrCC4aPP4hMTGV69SoYjQFXVA3GKdtU1evl4e8YnC0DmKrk0vUzIU/DoDXJGXnQ4zw== X-Gm-Gg: Acq92OEMlfdTJgWdKsPJ2FfMWY+BavFZT7dG9VApjfmFU9vwpFjPQHGuBSCjL9wG449 XxMCRfqsto0brbt/lQwDyKVl/9oDtBR/Iz3v/RF+wEzsdhDmYiHDKRRiPXnVp0xi8hnrNc+frQI PwnM3WaFrBzu532Gf1+Aw1NbeJTj8Y8PJ2Y2aPBSyh5UNg/Qhd7k8An+hydA/rLDOKezsOAB2RI tqSzYrAowozf4+sLU4tTidcxJTZT3rjWJO4qp7S+AtvJANTpbplBvWehIgJ8FUG0jI6+CNcusOt 9/kWGw13USg3D1ujouClw0Rmzy6U26tSetxPRaUc03eUrMYJcoO09TlKsMiSgtbaAw544LQzptG 0sC3VSQOb7T1U9qmp0j26R0jSFceIH9T10N4QGMxKXW46iVTJNE64GIYav6uF2Nxbg8LS9gbI7H iVE4sm X-Received: by 2002:a05:600c:a30a:b0:48e:62ec:f264 with SMTP id 5b1f17b1804b1-48fe61f29femr172075275e9.17.1779100647514; Mon, 18 May 2026 03:37:27 -0700 (PDT) X-Received: by 2002:a05:600c:a30a:b0:48e:62ec:f264 with SMTP id 5b1f17b1804b1-48fe61f29femr172074825e9.17.1779100647017; Mon, 18 May 2026 03:37:27 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe5ab52a6sm244036005e9.10.2026.05.18.03.37.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 03:37:26 -0700 (PDT) From: Javier Martinez Canillas To: Sen Wang , ple@baylibre.com, neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com Cc: andrzej.hajda@intel.com, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, devarsht@ti.com, s-jain1@ti.com, j-sahu@ti.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sen Wang Subject: Re: [PATCH v2] drm/bridge: ite-it66121: Convert to DRM HDMI Audio Helper In-Reply-To: <87ecj9xb70.fsf@ocarina.mail-host-address-is-not-set> References: <20260318154636.3230454-1-sen@ti.com> <87ecj9xb70.fsf@ocarina.mail-host-address-is-not-set> Date: Mon, 18 May 2026 12:37:25 +0200 Message-ID: <87bjedxau2.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Javier Martinez Canillas writes: > Sen Wang writes: > > Hello Sen, > >> Convert the IT66121 HDMI bridge driver from manually registering an >> hdmi-codec platform device to using the DRM HDMI Audio Helper framework >> via DRM_BRIDGE_OP_HDMI_AUDIO instead. >> >> The previous implementation manually allocated hdmi_codec_pdata, >> registered the platform device, and implemented hdmi_codec_ops callbacks >> including get_eld. The new approach sets DRM_BRIDGE_OP_HDMI_AUDIO on the >> bridge, letting the framework handle the codec registration. This also >> resolves some non-compliance issues with the current audio implementation, >> such as HDMI audio advertising a non-functional capture stream to userspace. >> >> The audio callbacks are converted from hdmi_codec_ops signatures to >> drm_bridge_funcs hdmi_audio callbacks: >> - it66121_audio_hw_params -> it66121_hdmi_audio_prepare >> - it66121_audio_startup -> it66121_hdmi_audio_startup >> - it66121_audio_shutdown -> it66121_hdmi_audio_shutdown >> - it66121_audio_mute -> it66121_hdmi_audio_mute_stream >> >> The it66121_audio_get_eld, it66121_audio_codec_ops, and >> it66121_audio_codec_init functions are removed as the framework handles >> these responsibilities. >> >> Suggested-by: Dmitry Baryshkov >> Signed-off-by: Sen Wang >> --- > > The patch looks correct to me but I'm not that familiar with the HDMI > helpers, so it would be great if either Dmitry or Maxime could take a > look to the changes before merging it. > > Reviewed-by: Javier Martinez Canillas > Actually, I noticed now that Dmitry already provided an r-b tag. I'll wait for a few more days and merge this by the end of the week then. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat