From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: Johannes Roith <johannes@gnu-linux.rocks>
Cc: ak@it-klinger.de, andi.shyti@kernel.org,
benjamin.tissoires@redhat.com, christophe.jaillet@wanadoo.fr,
jikos@kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH v5] hid-mcp2200: added driver for GPIOs of MCP2200
Date: Fri, 08 Sep 2023 01:34:53 +0000 [thread overview]
Message-ID: <87bkedv45j.fsf@protonmail.com> (raw)
In-Reply-To: <20230907164121.21092-1-johannes@gnu-linux.rocks>
Hi Johannes,
On Thu, 07 Sep, 2023 18:41:21 +0200 "Johannes Roith" <johannes@gnu-linux.rocks> wrote:
> Hi Rahul,
>
> thank you for the explanation, now I got it.
>
> I have added hid_hw_stop and hid_hw_close to my remove function and removed the
> devm_add_action_or_reset. The driver still worked well.
Glad to hear this worked out. This discussion has motivated me to take a
deeper look at hid_device_remove in the near future to see what can be
done for devices that need to invoke hid_hw_open without needing to
explicitly implement a remove callback.
>
> So, if it is okay for you, I would go this way and generate a new patch.
This sounds great. Excited to see your patch on the mailing list.
--
Thanks,
Rahul Rameshbabu
next prev parent reply other threads:[~2023-09-08 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 19:09 Rahul Rameshbabu
2023-09-07 16:41 ` Johannes Roith
2023-09-08 1:34 ` Rahul Rameshbabu [this message]
2023-09-18 15:14 ` [PATCH v6] HID: mcp2200: " Johannes Roith
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 10:48 [PATCH v5] hid-mcp2200: " johannes
2023-08-19 16:42 ` Rahul Rameshbabu
2023-08-31 18:53 ` Johannes Roith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkedv45j.fsf@protonmail.com \
--to=sergeantsagara@protonmail.com \
--cc=ak@it-klinger.de \
--cc=andi.shyti@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jikos@kernel.org \
--cc=johannes@gnu-linux.rocks \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome