From: Javier Martinez Canillas <javierm@redhat.com>
To: Pierre Asselin <pa@panix.com>, dri-devel@lists.freedesktop.org
Cc: Pierre Asselin <pa@panix.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Ard Biesheuvel <ardb@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] firmware/sysfb: Fix VESA format selection
Date: Wed, 19 Apr 2023 10:21:07 +0200 [thread overview]
Message-ID: <87bkjki8p8.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20230419044834.10816-1-pa@panix.com>
Pierre Asselin <pa@panix.com> writes:
Hello Pierre,
> Some legacy BIOSes report no reserved bits in their 32-bit rgb mode,
> breaking the calculation of bits_per_pixel in commit f35cd3fa7729
> [firmware/sysfb: Fix EFI/VESA format selection]. However they report
> lfb_depth correctly for those modes. Keep the computation but
> set bits_per_pixel to lfb_depth if the latter is larger.
>
> v2 fixes the warnings from a max3() macro with arguments of different
> types; split the bits_per_pixel assignment to avoid uglyfing the code
> with too many typecasts.
>
> Link: https://lore.kernel.org/r/4Psm6B6Lqkz1QXM@panix3.panix.com
> Link: https://lore.kernel.org/r/20230412150225.3757223-1-javierm@redhat.com
> Fixes: f35cd3fa7729 [firmware/sysfb: Fix EFI/VESA format selection]
The convention is f35cd3fa7729 ("firmware/sysfb: Fix EFI/VESA format selection")
> Signed-off-by: Pierre Asselin <pa@panix.com>
> ---
[...]
> + bits_per_pixel= max(bits_per_pixel, (u32)si->lfb_depth);
You are missing a space here.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-04-19 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 4:48 Pierre Asselin
2023-04-19 7:14 ` Thomas Zimmermann
2023-04-19 20:27 ` Pierre Asselin
2023-04-20 8:22 ` Thomas Zimmermann
2023-04-19 8:21 ` Javier Martinez Canillas [this message]
2023-04-19 19:56 ` Pierre Asselin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkjki8p8.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=ardb@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pa@panix.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®