From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57953C3DA79 for ; Fri, 16 Dec 2022 03:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229730AbiLPDDd (ORCPT ); Thu, 15 Dec 2022 22:03:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiLPDDa (ORCPT ); Thu, 15 Dec 2022 22:03:30 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BFC75E0A2; Thu, 15 Dec 2022 19:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671159809; x=1702695809; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=gCrxsFtqjirdLVPFluZe2uGgcAEuFJc+TUH1x+Gd2rA=; b=m7/DH1rjMaciifsGLyVJoD5pIxLba46DK3KGk0jZiPLl3I6Yp8UpuFLv IQP3CZjwklLKMtrH3DJaXKNIQR9Q19vRVuxrRIeprMHHOlOzybfKkcJxP kQBRbpz8SuedG1fiOZkq1Q4IuU7cwxu6Uq+AAwyrmphMJHNJk0+pyQ4Yq YApvYhzdxjziD2uyQlMJO8rAVvYzpIzZ16GLgTJtRg+93KW13MKPuSnnj 0FAYYCm0JtY33tkRIX/eR13ejABUvRrxvk6oo70f4K50xo5zgCI7phiFk n3XP/MO1jH4P+nuHA/5yVjLU9YfQimjRF19SlGZeOic3gdxNxhFQGMBXZ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="298538145" X-IronPort-AV: E=Sophos;i="5.96,248,1665471600"; d="scan'208";a="298538145" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 19:03:28 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="599794438" X-IronPort-AV: E=Sophos;i="5.96,248,1665471600"; d="scan'208";a="599794438" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 19:03:22 -0800 From: "Huang, Ying" To: Michal Hocko Cc: Mina Almasry , Johannes Weiner , Tejun Heo , Zefan Li , Jonathan Corbet , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, bagasdotme@gmail.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: Add nodes= arg to memory.reclaim References: <20221202223533.1785418-1-almasrymina@google.com> <87k02volwe.fsf@yhuang6-desk2.ccr.corp.intel.com> <87mt7pdxm1.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Fri, 16 Dec 2022 11:02:22 +0800 In-Reply-To: (Michal Hocko's message of "Thu, 15 Dec 2022 10:21:25 +0100") Message-ID: <87bko49hkx.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Hocko writes: > On Thu 15-12-22 13:50:14, Huang, Ying wrote: >> Michal Hocko writes: >> >> > On Tue 13-12-22 11:29:45, Mina Almasry wrote: >> >> On Tue, Dec 13, 2022 at 6:03 AM Michal Hocko wrote: >> >> > >> >> > On Tue 13-12-22 14:30:40, Johannes Weiner wrote: >> >> > > On Tue, Dec 13, 2022 at 02:30:57PM +0800, Huang, Ying wrote: >> >> > [...] >> >> > > > After these discussion, I think the solution maybe use different >> >> > > > interfaces for "proactive demote" and "proactive reclaim". That is, >> >> > > > reconsider "memory.demote". In this way, we will always uncharge the >> >> > > > cgroup for "memory.reclaim". This avoid the possible confusion there. >> >> > > > And, because demotion is considered aging, we don't need to disable >> >> > > > demotion for "memory.reclaim", just don't count it. >> >> > > >> >> > > Hm, so in summary: >> >> > > >> >> > > 1) memory.reclaim would demote and reclaim like today, but it would >> >> > > change to only count reclaimed pages against the goal. >> >> > > >> >> > > 2) memory.demote would only demote. >> >> > > >> >> >> >> If the above 2 points are agreeable then yes, this sounds good to me >> >> and does address our use case. >> >> >> >> > > a) What if the demotion targets are full? Would it reclaim or fail? >> >> > > >> >> >> >> Wei will chime in if he disagrees, but I think we _require_ that it >> >> fails, not falls back to reclaim. The interface is asking for >> >> demotion, and is called memory.demote. For such an interface to fall >> >> back to reclaim would be very confusing to userspace and may trigger >> >> reclaim on a high priority job that we want to shield from proactive >> >> reclaim. >> > >> > But what should happen if the immediate demotion target is full but >> > lower tiers are still usable. Should the first one demote before >> > allowing to demote from the top tier? >> > >> >> > > 3) Would memory.reclaim and memory.demote still need nodemasks? >> >> >> >> memory.demote will need a nodemask, for sure. Today the nodemask would >> >> be useful if there is a specific node in the top tier that is >> >> overloaded and we want to reduce the pressure by demoting. In the >> >> future there will be N tiers and the nodemask says which tier to >> >> demote from. >> > >> > OK, so what is the exact semantic of the node mask. Does it control >> > where to demote from or to or both? >> > >> >> I don't think memory.reclaim would need a nodemask anymore? At least I >> >> no longer see the use for it for us. >> >> >> >> > > Would >> >> > > they return -EINVAL if a) memory.reclaim gets passed only toptier >> >> > > nodes or b) memory.demote gets passed any lasttier nodes? >> >> > >> >> >> >> Honestly it would be great if memory.reclaim can force reclaim from a >> >> top tier nodes. It breaks the aginig pipeline, yes, but if the user is >> >> specifically asking for that because they decided in their usecase >> >> it's a good idea then the kernel should comply IMO. Not a strict >> >> requirement for us. Wei will chime in if he disagrees. >> > >> > That would require a nodemask to say which nodes to reclaim, no? The >> > default behavior should be in line with what standard memory reclaim >> > does. If the demotion is a part of that process so should be >> > memory.reclaim part of it. If we want to have a finer control then a >> > nodemask is really a must and then the nodemaks should constrain both >> > agining and reclaim. >> > >> >> memory.demote returning -EINVAL for lasttier nodes makes sense to me. >> >> >> >> > I would also add >> >> > 4) Do we want to allow to control the demotion path (e.g. which node to >> >> > demote from and to) and how to achieve that? >> >> >> >> We care deeply about specifying which node to demote _from_. That >> >> would be some node that is approaching pressure and we're looking for >> >> proactive saving from. So far I haven't seen any reason to control >> >> which nodes to demote _to_. The kernel deciding that based on the >> >> aging pipeline and the node distances sounds good to me. Obviously >> >> someone else may find that useful. >> > >> > Please keep in mind that the interface should be really prepared for >> > future extensions so try to abstract from your immediate usecases. >> >> I see two requirements here, one is to control the demotion source, that >> is, which nodes to free memory. The other is to control the demotion >> path. I think that we can use two different parameters for them, for >> example, "from=" and "to=> nodes>". In most cases we don't need to control the demotion path. >> Because in current implementation, the nodes in the lower tiers in the >> same socket (local nodes) will be preferred. I think that this is >> the desired behavior in most cases. > > Even if the demotion path is not really required at the moment we should > keep in mind future potential extensions. E.g. when a userspace based > balancing is to be implemented because the default behavior cannot > capture userspace policies (one example would be enforcing a > prioritization of containers when some container's demoted pages would > need to be demoted further to free up a space for a different > workload). Yes. We should consider the potential requirements. >> >> > 5) Is the demotion api restricted to multi-tier systems or any numa >> >> > configuration allowed as well? >> >> > >> >> >> >> demotion will of course not work on single tiered systems. The >> >> interface may return some failure on such systems or not be available >> >> at all. >> > >> > Is there any strong reason for that? We do not have any interface to >> > control NUMA balancing from userspace. Why cannot we use the interface >> > for that purpose? >> >> Do you mean to demote the cold pages from the specified source nodes to >> the specified target nodes in different sockets? We don't do that to >> avoid loop in the demotion path. If we prevent the target nodes from >> demoting cold pages to the source nodes at the same time, it seems >> doable. > > Loops could be avoid by properly specifying from and to nodes if this is > going to be a fine grained interface to control demotion. Yes. Best Regards, Huang, Ying