From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2CEC4332F for ; Thu, 10 Nov 2022 14:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231331AbiKJO3E (ORCPT ); Thu, 10 Nov 2022 09:29:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231373AbiKJO2n (ORCPT ); Thu, 10 Nov 2022 09:28:43 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F92625EE for ; Thu, 10 Nov 2022 06:28:40 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B6911F9F0; Thu, 10 Nov 2022 14:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668090519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XmURArnxcG2DBVBmhfZJ9se8qGoCeEY03n+z1EX2pm0=; b=mH71tTawOS56tumMmlyNBL2KHVe+3HDDriY6K/rAK5O3x8F5qIWKCNdO1WVvFsr32JoNc1 9SLXQFhOcZZzTuGLnSyA9rwPZVuhu4JFkrHAqWxHV7V4jp92jEXRXVz0EQ9jNSG+TmlTbj Mq1PlFzPqHGdlEofKI4OqyTXV1etNHs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668090519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XmURArnxcG2DBVBmhfZJ9se8qGoCeEY03n+z1EX2pm0=; b=Exn7NPMvKhJRKCgxzoyo+gVzVDSNAemsTS9Q/b2rtUNGmjW5FnpcePAjoGPRBymVPnCQ43 Ah1YsQ3Tvmvh9FCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0B7281332F; Thu, 10 Nov 2022 14:28:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 88h5ApcKbWP3IwAAMHmgww (envelope-from ); Thu, 10 Nov 2022 14:28:39 +0000 Date: Thu, 10 Nov 2022 15:28:38 +0100 Message-ID: <87bkpeq3xl.wl-tiwai@suse.de> From: Takashi Iwai To: Ye Bin Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, yebin10@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: fix potential memleak in 'add_widget_node' In-Reply-To: <20221110144539.2989354-1-yebin@huaweicloud.com> References: <20221110144539.2989354-1-yebin@huaweicloud.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Nov 2022 15:45:39 +0100, Ye Bin wrote: > > From: Ye Bin > > As 'kobject_add' may allocated memory for 'kobject->name' when return error. > And in this function, if call 'kobject_add' failed didn't free kobject. > So call 'kobject_put' to recycling resources. > > Signed-off-by: Ye Bin Thanks, applied now. Takashi