From: ebiederm@xmission.com (Eric W. Biederman)
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Christian Brauner" <christian@brauner.io>,
"Hridya Valsaraju" <hridya@google.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: binderfs interferes with syzkaller?
Date: Tue, 28 Jan 2020 07:46:08 -0600 [thread overview]
Message-ID: <87blqn3d9b.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20200126093506.oa2ee5kbptur4zhz@wittgenstein> (Christian Brauner's message of "Sun, 26 Jan 2020 10:35:07 +0100")
Christian Brauner <christian.brauner@ubuntu.com> writes:
> On Sun, Jan 26, 2020 at 09:55:35AM +0100, Greg Kroah-Hartman wrote:
>> On Sat, Jan 25, 2020 at 06:49:49PM +0100, Dmitry Vyukov wrote:
>> > Hi binder maintainers,
>> >
>> > It seems that something has happened and now syzbot has 0 coverage in
>> > drivers/android/binder.c:
>> > https://storage.googleapis.com/syzkaller/cover/ci-upstream-kasan-gce-root.html
>> > It covered at least something there before as it found some bugs in binder code.
>> > I _suspect_ it may be related to introduction binderfs, but it's
>> > purely based on the fact that binderfs changed lots of things there.
>> > And I see it claims to be backward compatible.
>>
>> It is backwards compatible if you mount binderfs, right?
>
> Yes, it is backwards compatible. The devices that would usually be
> created in devtmpfs are now created in binderfs. The core
> binder-codepaths are the same.
Any chance you can add code to the binderfs case to automatically
create the symlinks to the standard mount location in devtmpfs?
That way existing userspace might not need to care how the kernel is
configured.
Eric
next prev parent reply other threads:[~2020-01-28 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 17:49 Dmitry Vyukov
2020-01-25 18:13 ` Dmitry Vyukov
2020-01-26 9:51 ` Christian Brauner
2020-01-27 17:11 ` Dmitry Vyukov
2020-01-26 8:55 ` Greg Kroah-Hartman
2020-01-26 9:35 ` Christian Brauner
2020-01-28 13:46 ` Eric W. Biederman [this message]
2020-01-28 13:54 ` Christian Brauner
2020-01-27 16:47 ` Todd Kjos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blqn3d9b.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=arve@android.com \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=syzkaller@googlegroups.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®