mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH v2 2/2] drm/vc4: Disable V3D interactions if the v3d component didn't probe.
Date: Wed, 03 Apr 2019 12:15:29 -0700	[thread overview]
Message-ID: <87bm1moq7i.fsf@anholt.net> (raw)
In-Reply-To: <c153b5bf62825718216dc54a2f79c291f84eb24f.camel@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

Paul Kocialkowski <paul.kocialkowski@bootlin.com> writes:

> Hi,
>
> On Mon, 2019-04-01 at 11:35 -0700, Eric Anholt wrote:
>> One might want to use the VC4 display stack without using Mesa.
>> Similar to the debugfs fixes for not having all of the possible
>> display bits enabled, make sure you can't oops in vc4 if v3d isn't
>> enabled.
>
> Just thought about this: perhaps we should be returning -ENODEV instead
> of -EINVAL when !vc4->v3d, just so that the error is a bit more
> explicit to userspace?

I like it.  Doing that while applying the series.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-04-03 19:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 18:35 [PATCH v2 1/2] drm/vc4: Use common helpers for debugfs setup by the driver components Eric Anholt
2019-04-01 18:35 ` [PATCH v2 2/2] drm/vc4: Disable V3D interactions if the v3d component didn't probe Eric Anholt
2019-04-02 14:27   ` Paul Kocialkowski
2019-04-03 13:30   ` Paul Kocialkowski
2019-04-03 19:15     ` Eric Anholt [this message]
2019-04-02 14:38 ` [PATCH v2 1/2] drm/vc4: Use common helpers for debugfs setup by the driver components Paul Kocialkowski
2019-04-03  9:17 ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm1moq7i.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome