From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: <twischer@de.adit-jv.com>
Cc: <patch@alsa-project.org>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>,
Jiada Wang <jiada_wang@mentor.com>
Subject: Re: [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address
Date: 25 Feb 2019 10:15:39 +0900 [thread overview]
Message-ID: <87bm303cie.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <1550823803-32446-1-git-send-email-twischer@de.adit-jv.com>
Hi Jiada
Thank you for your patch
> Currently each SSI unit 's busif dma address is calculated by
> following calculation formulation:
> 0xec540000 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400
>
> But according to user manual 41.1.4 Register Configuration
> ssi9 4/5/6/7 busif data register address
> (SSI9_4_BUSIF/SSI9_5_BUSIF/SSI9_6_BUSIF/SSI9_7_BUSIF)
> are out of this rule.
>
> This patch updates the calculation formulation to correct
> ssi9 4/5/6/7 busif data register address
>
> Fixes: commit 5e45a6fab3b9 ("ASoc: rsnd: dma: Calculate dma address with consider of BUSIF")
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
> ---
We don't need below anymore by this patch ?
--- dma.c ----
/*
* FIXME
*
* We can't support SSI9-4/5/6/7, because its address is
* out of calculation rule
*/
if ((id == 9) && (busif >= 4))
dev_err(dev, "This driver doesn't support SSI%d-%d, so far",
id, busif);
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2019-02-25 1:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 8:23 twischer
2019-02-25 1:15 ` Kuninori Morimoto [this message]
2019-02-25 1:18 ` Kuninori Morimoto
2019-10-22 15:49 ` [alsa-devel] " Eugeniu Rosca
2019-10-22 16:35 ` Mark Brown
2019-10-22 16:46 ` Eugeniu Rosca
2019-10-22 16:53 ` Mark Brown
2019-10-22 18:59 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm303cie.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jiada_wang@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patch@alsa-project.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=twischer@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®