From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 0/8] Remove unneccessary included headers
Date: Thu, 31 May 2018 19:55:03 +1000 [thread overview]
Message-ID: <87bmcwywso.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <cover.1527697995.git.christophe.leroy@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> The purpose of this serie is to limit the number of includes to
> only the necessary ones in order to reduce the number of files
> recompiled everytime a header file is modified.
>
> This is the start of the work, please provide feedback if any so
> that I don't go in the wrong direction.
Thanks for starting on this.
There's a few build errors, summary below.
http://kisskb.ellerman.id.au/kisskb/head/14031/
cheers
arch/powerpc/kernel/machine_kexec.c:140:26: error: 'KDUMP_KERNELBASE' undeclared (first use in this function):
corenet32_smp_defconfig powerpc
corenet32_smp_defconfig powerpc-5.3
g5_defconfig powerpc
g5_defconfig powerpc-5.3
gamecube_defconfig powerpc
gamecube_defconfig powerpc-5.3
maple_defconfig powerpc
maple_defconfig powerpc-5.3
mpc85xx_defconfig powerpc
mpc85xx_defconfig powerpc-5.3
mpc85xx_smp_defconfig powerpc
mpc85xx_smp_defconfig powerpc-5.3
mpc86xx_defconfig powerpc
mpc86xx_defconfig powerpc-5.3
powernv_defconfig+NO_NUMA ppc64le
powernv_defconfig+NO_PERF ppc64le
powernv_defconfig+NO_RADIX ppc64le
powernv_defconfig+STRICT_RWX ppc64le
powernv_defconfig+THIN ppc64le
powerpc-randconfig powerpc-5.3
ppc64e_defconfig+KEXEC powerpc
ppc64e_defconfig+KEXEC powerpc-5.3
ps3_defconfig powerpc
ps3_defconfig powerpc-5.3
pseries_defconfig powerpc
pseries_defconfig powerpc-5.3
pseries_defconfig+NO_MEMORY_HOTPLUG powerpc
pseries_defconfig+NO_MEMORY_HOTPLUG powerpc-5.3
pseries_defconfig+NO_MEMORY_HOTREMOVE powerpc
pseries_defconfig+NO_SPLPAR powerpc
pseries_defconfig+NO_SPLPAR powerpc-5.3
pseries_le_defconfig ppc64le
pseries_le_defconfig+NO_NUMA ppc64le
pseries_le_defconfig+NO_SPLPAR ppc64le
skiroot_defconfig ppc64le
wii_defconfig powerpc
wii_defconfig powerpc-5.3
arch/powerpc/include/asm/cputable.h:146:23: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
amigaone_defconfig powerpc-5.3
corenet_basic_defconfig powerpc-5.3
holly_defconfig powerpc-5.3
mpc85xx_basic_defconfig powerpc-5.3
pmac32_defconfig powerpc-5.3
pmac32_defconfig+KVM powerpc-5.3
pmac32_defconfig+kexec powerpc-5.3
arch/powerpc/include/asm/cputable.h:538:6: error: enumerator value for 'CPU_FTRS_POSSIBLE' is not an integer constant:
44x/akebono_defconfig powerpc
44x/akebono_defconfig powerpc-5.3
44x/currituck_defconfig powerpc
44x/currituck_defconfig powerpc-5.3
amigaone_defconfig powerpc
amigaone_defconfig powerpc-5.3
chrp32_defconfig powerpc
chrp32_defconfig powerpc-5.3
corenet_basic_defconfig powerpc
corenet_basic_defconfig powerpc-5.3
holly_defconfig powerpc
holly_defconfig powerpc-5.3
mpc85xx_basic_defconfig powerpc
mpc85xx_basic_defconfig powerpc-5.3
pmac32_defconfig powerpc
pmac32_defconfig powerpc-5.3
pmac32_defconfig+KVM powerpc
pmac32_defconfig+KVM powerpc-5.3
pmac32_defconfig+SMP powerpc
pmac32_defconfig+SMP powerpc-5.3
pmac32_defconfig+kexec powerpc
pmac32_defconfig+kexec powerpc-5.3
ppc6xx_defconfig powerpc
ppc6xx_defconfig powerpc-5.3
arch/powerpc/include/asm/cputable.h:614:6: error: enumerator value for 'CPU_FTRS_ALWAYS' is not an integer constant:
44x/akebono_defconfig powerpc
44x/akebono_defconfig powerpc-5.3
44x/currituck_defconfig powerpc
44x/currituck_defconfig powerpc-5.3
amigaone_defconfig powerpc
amigaone_defconfig powerpc-5.3
chrp32_defconfig powerpc
chrp32_defconfig powerpc-5.3
corenet_basic_defconfig powerpc
corenet_basic_defconfig powerpc-5.3
holly_defconfig powerpc
holly_defconfig powerpc-5.3
mpc85xx_basic_defconfig powerpc
mpc85xx_basic_defconfig powerpc-5.3
pmac32_defconfig powerpc
pmac32_defconfig powerpc-5.3
pmac32_defconfig+KVM powerpc
pmac32_defconfig+KVM powerpc-5.3
pmac32_defconfig+SMP powerpc
pmac32_defconfig+SMP powerpc-5.3
pmac32_defconfig+kexec powerpc
pmac32_defconfig+kexec powerpc-5.3
ppc6xx_defconfig powerpc
ppc6xx_defconfig powerpc-5.3
arch/powerpc/include/asm/cputable.h:505:6: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
amigaone_defconfig powerpc
chrp32_defconfig powerpc
corenet_basic_defconfig powerpc
holly_defconfig powerpc
mpc85xx_basic_defconfig powerpc
pmac32_defconfig powerpc
pmac32_defconfig+KVM powerpc
pmac32_defconfig+SMP powerpc
pmac32_defconfig+kexec powerpc
ppc6xx_defconfig powerpc
arch/powerpc/kernel/machine_kexec.c:155:22: error: 'KDUMP_KERNELBASE' undeclared (first use in this function):
44x/fsp2_defconfig powerpc-5.3
arch/powerpc/include/asm/cputable.h:158:32: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
44x/akebono_defconfig powerpc-5.3
44x/currituck_defconfig powerpc-5.3
chrp32_defconfig powerpc-5.3
pmac32_defconfig+SMP powerpc-5.3
ppc6xx_defconfig powerpc-5.3
arch/powerpc/include/asm/cputable.h:515:6: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
44x/akebono_defconfig powerpc
44x/currituck_defconfig powerpc
prev parent reply other threads:[~2018-05-31 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 16:41 Christophe Leroy
2018-05-30 16:41 ` [RFC PATCH 1/8] powerpc: remove kdump.h from page.h Christophe Leroy
2018-05-30 16:41 ` [RFC PATCH 2/8] powerpc: remove unneeded inclusions of cpu_has_feature.h Christophe Leroy
2018-05-30 16:41 ` [RFC PATCH 3/8] powerpc: remove superflous inclusions of asm-compat.h Christophe Leroy
2018-05-30 16:41 ` [RFC PATCH 4/8] powerpc: remove superflous inclusions of asm/feature-fixups.h Christophe Leroy
2018-05-30 16:41 ` [RFC PATCH 5/8] powerpc: remove superflous inclusions of asm/fixmap.h Christophe Leroy
2018-05-30 16:41 ` [RFC PATCH 6/8] powerpc: declare set_breakpoint() static Christophe Leroy
2018-05-30 16:41 ` [RFC PATCH 7/8] powerpc/book3s: Remove PPC_PIN_SIZE Christophe Leroy
2018-05-30 16:42 ` [RFC PATCH 8/8] powerpc: fix includes in asm/processor.h Christophe Leroy
2018-05-31 9:55 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmcwywso.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®