From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750837AbeAOWbt convert rfc822-to-8bit (ORCPT + 1 other); Mon, 15 Jan 2018 17:31:49 -0500 Received: from ozlabs.org ([103.22.144.67]:35951 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbeAOWbr (ORCPT ); Mon, 15 Jan 2018 17:31:47 -0500 From: Michael Ellerman To: Chris Packham , Christophe JAILLET , Borislav Petkov Cc: "mchehab\@kernel.org" , "linux-edac\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "kernel-janitors\@vger.kernel.org" , "linuxppc-dev\@lists.ozlabs.org" Subject: Re: [PATCH] EDAC, mv64x60: Remove some code duplication In-Reply-To: <68939e8b999644b89080ed049970c9fe@svr-chch-ex1.atlnz.lc> References: <20180113072821.8100-1-christophe.jaillet@wanadoo.fr> <20180113142212.fuuvq2x2bey7qv4s@pd.tnic> <49db37d7-3d54-3ae5-9cb9-702ef14f1f43@wanadoo.fr> <68939e8b999644b89080ed049970c9fe@svr-chch-ex1.atlnz.lc> Date: Tue, 16 Jan 2018 09:31:45 +1100 Message-ID: <87bmhubvou.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Chris Packham writes: > On 14/01/18 06:17, Christophe JAILLET wrote: >> Le 13/01/2018 à 15:22, Borislav Petkov a écrit : >>> + Chris Packham who's been fixing some stuff in here too. >>> >>> On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: >>>> Reorder the error handling code in order to release the resources in >>>> reverse order than allocation. >>>> >>>> Introduce a new 'release_group' label in the error handling path and use >>>> it to void some code duplication. >>>> >>>> Signed-off-by: Christophe JAILLET >>>> --- >>>> drivers/edac/mv64x60_edac.c | 7 ++++--- >>>> 1 file changed, 4 insertions(+), 3 deletions(-) ... >>>> >>>> -- >>> Thanks, looks good. But looking at this driver, mv64x60_mc_err_probe() >>> and mv64x60_sram_err_probe() have the same problem too. Can you address them >>> with your patch too pls? >> Will do. mv64x60_pci_err_probe() also needs some tweaks. >> >>> Also, if you feel like fixing more stuff in this driver, it doesn't use >>> the edac_printk() infrastructure but naked printk() calls. It could be >>> converted to it. >> I will only propose to remove a useless message and improve another one, >> but won't convert the whole driver, sorry. >> > > I take this you mean you have a system with a mv64x60 SoC? You might > want to make yourself known to the linuxppc-dev list. A while back the > prospects of dropping CONFIG_MV64X60 was raised[1]. I don't see anyone > actually following through on this yet but I'm not really following > linuxppc that closely. That's just because I haven't had time to do it and no one else took the hint :) So yes, Christophe if you have a machine that uses this driver please speak up, otherwise it will probably be removed. cheers