From: Michael Ellerman <mpe@ellerman.id.au>
To: Thierry Reding <thierry.reding@gmail.com>,
David Miller <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Ding Tianhong <dingtianhong@huawei.com>
Cc: leedom@chelsio.com, ashok.raj@intel.com, werner@chelsio.com,
ganeshgr@chelsio.com, asit.k.mallick@intel.com,
patrick.j.cramer@intel.com, Suravee.Suthikulpanit@amd.com,
Bob.Shaw@amd.com, l.stach@pengutronix.de, amira@mellanox.com,
gabriele.paoloni@huawei.com, David.Laight@aculab.com,
jeffrey.t.kirsher@intel.com, catalin.marinas@arm.com,
will.deacon@arm.com, mark.rutland@arm.com, robin.murphy@arm.com,
alexander.duyck@gmail.com, eric.dumazet@gmail.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH] PCI: Allow PCI express root ports to find themselves
Date: Fri, 18 Aug 2017 14:32:36 +1000 [thread overview]
Message-ID: <87bmndqyvv.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170817110614.11454-1-thierry.reding@gmail.com>
Thierry Reding <thierry.reding@gmail.com> writes:
> From: Thierry Reding <treding@nvidia.com>
>
> If the pci_find_pcie_root_port() function is called on a root port
> itself, return the root port rather than NULL.
>
> This effectively reverts commit 0e405232871d6 ("PCI: fix oops when
> try to find Root Port for a PCI device") which added an extra check
> that would now be redundant.
>
> Fixes: a99b646afa8a ("PCI: Disable PCIe Relaxed Ordering if unsupported")
> Fixes: c56d4450eb68 ("PCI: Turn off Request Attributes to avoid Chelsio T5 Completion erratum")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> This applies on top of and was tested on next-20170817.
>
> Michael, it'd be great if you could test this one again to clarify
> whether or not the fix that's already in Linus' tree is still needed, or
> whether it's indeed obsoleted by this patch.
This works fine for me, applied on top of Linus' tree (d33a2a914319).
cheers
next prev parent reply other threads:[~2017-08-18 4:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 2:25 [PATCH net] PCI: fix the return value for the pci_find_pcie_root_port() Ding Tianhong
2017-08-17 2:42 ` David Miller
2017-08-17 10:51 ` Thierry Reding
2017-08-17 12:40 ` Ding Tianhong
2017-08-17 13:30 ` Thierry Reding
2017-08-17 13:38 ` Ding Tianhong
2017-08-17 11:06 ` [PATCH] PCI: Allow PCI express root ports to find themselves Thierry Reding
2017-08-17 16:58 ` Bjorn Helgaas
2017-08-18 1:29 ` Shawn Lin
2017-08-18 4:32 ` Michael Ellerman [this message]
2017-08-18 23:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmndqyvv.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=Bob.Shaw@amd.com \
--cc=David.Laight@aculab.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=alexander.duyck@gmail.com \
--cc=amira@mellanox.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=eric.dumazet@gmail.com \
--cc=gabriele.paoloni@huawei.com \
--cc=ganeshgr@chelsio.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=l.stach@pengutronix.de \
--cc=leedom@chelsio.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=patrick.j.cramer@intel.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=werner@chelsio.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®