From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753566AbdC1AW5 (ORCPT ); Mon, 27 Mar 2017 20:22:57 -0400 Received: from ozlabs.org ([103.22.144.67]:35459 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbdC1AWz (ORCPT ); Mon, 27 Mar 2017 20:22:55 -0400 From: Michael Ellerman To: Bamvor Jian Zhang , luto@amacapital.net, shuahkh@osg.samsung.com Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@kernel.org, broonie@kernel.org, bamvor.zhangjian@huawei.com, bamvor.zhangjian@linaro.org Subject: Re: [PATCH 1/2] selftests: fix the broken individual test for x86 In-Reply-To: <20170327054601.22415-2-bamvor.zhangjian@linaro.org> References: <20170327054601.22415-1-bamvor.zhangjian@linaro.org> <20170327054601.22415-2-bamvor.zhangjian@linaro.org> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 28 Mar 2017 11:22:53 +1100 Message-ID: <87bmsm8d2a.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bamvor Jian Zhang writes: > Andy Lutomirski report that build individual testcase in x86 is broken: > > $ make -C tools/testing/selftests/x86 ldt_gdt_32 > make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86' > Makefile:44: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > make: *** No rule to make target 'ldt_gdt_32'. Stop. > make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86' > > This patch fix this issue by adding default OUTPUT and convert > target in Makefile of x86. > > And also mention this use case in Documentation/kselftests.txt > > Reported-by: Andy Lutomirski > Signed-off-by: Bamvor Jian Zhang > --- > Documentation/kselftest.txt | 6 ++++++ > tools/testing/selftests/x86/Makefile | 23 ++++++++++++++--------- > 2 files changed, 20 insertions(+), 9 deletions(-) I don't think this is a good fix, it only fixes this one Makefile, and it's quite verbose. But if it really bothers Andy then it would be OK as a stop-gap for 4.11. cheers