From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932304AbdA0Nox (ORCPT ); Fri, 27 Jan 2017 08:44:53 -0500 Received: from mga01.intel.com ([192.55.52.88]:23024 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932279AbdA0No3 (ORCPT ); Fri, 27 Jan 2017 08:44:29 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,295,1477983600"; d="scan'208";a="1118617913" From: Alexander Shishkin To: Peter Zijlstra , Dmitry Vyukov Cc: Ingo Molnar , Arnaldo Carvalho de Melo , LKML , syzkaller , Mathieu Desnoyers Subject: Re: perf: use-after-free in perf_event_for_each In-Reply-To: <20170126153955.GD6515@twins.programming.kicks-ass.net> References: <20170126153955.GD6515@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.23.3 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 27 Jan 2017 15:02:07 +0200 Message-ID: <87bmusbqr4.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Mon, Jan 23, 2017 at 02:30:12PM +0100, Dmitry Vyukov wrote: >> Hello, >> >> The following program triggers use-after-free in perf_event_for_each: >> https://gist.githubusercontent.com/dvyukov/f1c354a8356e42f4d0b3d912e1bec956/raw/31d7ecdf6dc2c7327b80ef8581a39c823bbe405d/gistfile1.txt >> >> BUG: KASAN: use-after-free in perf_event_for_each_child+0x15f/0x180 >> kernel/events/core.c:4495 at addr ffff8800680ec248 > > The below seems to fix things for me. FWIW, Reviewed-by: Alexander Shishkin