From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761178AbcJ1PwN (ORCPT ); Fri, 28 Oct 2016 11:52:13 -0400 Received: from anholt.net ([50.246.234.109]:38112 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759709AbcJ1PwL (ORCPT ); Fri, 28 Oct 2016 11:52:11 -0400 From: Eric Anholt To: Thomas Gleixner Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , bcm-kernel-feedback-list@broadcom.com, Jason Cooper , Marc Zyngier , Phil Elwell Subject: Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts In-Reply-To: References: <20161027182038.11312-1-eric@anholt.net> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 28 Oct 2016 08:52:08 -0700 Message-ID: <87bmy4qxnb.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Gleixner writes: > On Thu, 27 Oct 2016, Eric Anholt wrote: > >> From: Phil Elwell >> >> The old arch-specific IRQ macros included a dsb to ensure the >> write to clear the mailbox interrupt completed before returning >> from the interrupt. The BCM2836 irqchip driver needs the same >> precaution to avoid spurious interrupts. > > This is missing a fixes tag. I have no idea when that problem was > introduced, so I have no way to decide whether this needs to be tagged > stable or not. This code has been there since introduction of the driver, so: Fixes: 1a15aaa998dc ("irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2")