From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751392AbcGWU7Q (ORCPT <rfc822;w@1wt.eu>);
	Sat, 23 Jul 2016 16:59:16 -0400
Received: from mga14.intel.com ([192.55.52.115]:23214 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751264AbcGWU7P (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 Jul 2016 16:59:15 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,410,1464678000"; 
   d="scan'208";a="1022638352"
From: Andi Kleen <andi@firstfloor.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Michal Hocko <mhocko@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>, Mel Gorman <mgorman@suse.de>,
        Johannes Weiner <hannes@cmpxchg.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: optimize copy_page_to/from_iter_iovec
References: <alpine.LRH.2.02.1607221656530.4818@file01.intranet.prod.int.rdu2.redhat.com>
	<alpine.LRH.2.02.1607221711410.4818@file01.intranet.prod.int.rdu2.redhat.com>
Date: Sat, 23 Jul 2016 13:59:13 -0700
In-Reply-To: <alpine.LRH.2.02.1607221711410.4818@file01.intranet.prod.int.rdu2.redhat.com>
	(Mikulas Patocka's message of "Fri, 22 Jul 2016 17:12:46 -0400 (EDT)")
Message-ID: <87bn1onk9q.fsf@tassilo.jf.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Mikulas Patocka <mpatocka@redhat.com> writes:
>  	copy = min(bytes, iov->iov_len - skip);
>  
> +#ifdef CONFIG_HIGHMEM
>  	if (!fault_in_pages_writeable(buf, copy)) {

If you use IS_ENABLED in the if here ...

>  	kunmap(page);
> +
> +#ifdef CONFIG_HIGHMEM
>  done:
> +#endif

... you don't need this ifdef.

-Andi


-- 
ak@linux.intel.com -- Speaking for myself only