From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbcEJHqa (ORCPT ); Tue, 10 May 2016 03:46:30 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:28657 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbcEJHq0 (ORCPT ); Tue, 10 May 2016 03:46:26 -0400 Date: Tue, 10 May 2016 16:46:24 +0900 Message-ID: <87bn4epd7z.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Rob Herring Cc: "devicetree@vger.kernel.org" , SH-Linux , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND 12/12] of: Add sh support In-Reply-To: References: <1462079316-27771-1-git-send-email-ysato@users.sourceforge.jp> <1462079316-27771-13-git-send-email-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 May 2016 21:35:28 +0900, Rob Herring wrote: > > On Sun, May 1, 2016 at 12:08 AM, Yoshinori Sato > wrote: > > sh fdt access in VA. But memory reservation use PA. > > So sh need convert to PA. > > > > Signed-off-by: Yoshinori Sato > > --- > > drivers/of/fdt.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > > index 3349d2a..fb357be 100644 > > --- a/drivers/of/fdt.c > > +++ b/drivers/of/fdt.c > > @@ -593,6 +593,9 @@ void __init early_init_fdt_scan_reserved_mem(void) > > fdt_get_mem_rsv(initial_boot_params, n, &base, &size); > > if (!size) > > break; > > +#ifdef CONFIG_SUPERH > > + base = virt_to_phys(base); > > +#endif > > early_init_dt_reserve_memory_arch(base, size, 0); > > This is not right. base is already a physical address and > early_init_dt_reserve_memory_arch takes a physical address. The > default implementation using memblock also works on physical > addresses. It is a weak function so you can override it if you need to > do something special. But it seems something else is wrong here if you > need this. Thank you very much for your advice. The function of the sh specific is defined. > Rob -- Yoshinori Sato