From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750966AbcCHSEt (ORCPT ); Tue, 8 Mar 2016 13:04:49 -0500 Received: from anholt.net ([50.246.234.109]:43197 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbcCHSEk (ORCPT ); Tue, 8 Mar 2016 13:04:40 -0500 From: Eric Anholt To: Stephen Warren Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Florian Fainelli , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie Subject: Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree. In-Reply-To: <56DE6A80.1060707@wwwdotorg.org> References: <1457123528-13482-1-git-send-email-eric@anholt.net> <1457123528-13482-4-git-send-email-eric@anholt.net> <56DE6A80.1060707@wwwdotorg.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 08 Mar 2016 10:04:35 -0800 Message-ID: <87bn6ozw0c.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stephen Warren writes: > On 03/04/2016 01:32 PM, Eric Anholt wrote: >> VC4 is the GPU (display and 3D) present on the 283x. > >> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dt= s/bcm2835-rpi-a-plus.dts > >> +&hdmi { >> + hpd-gpios =3D <&gpio 46 GPIO_ACTIVE_LOW>; >> +}; > > Isn't that the same everywhere? If so, adding it to bcm2835-rpi.dtsi=20 > seems like a better idea; it'd avoid duplicating it everywhere. It's not the same everywhere (_HIGH vs _LOW), which is why it's in the individual files. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJW3xQ0AAoJELXWKTbR/J7oqKgQAIvf7dwXxF5YWTpbqYHSLZM3 iABdxFdg/oe/a3sgmpJmlno/ETB4naKEwp+4RTJklZFQYFBTIDbaP2AarSWjmqxO du5IAMlv1usRqNyF7qGK3IsvE/jxY+67ZgRZZEIIGu73GXC2G0ckyQU4ZSCPUr+B JK2JewqqXl41f5Y1EZUlStyVy3lum2JuJzgQZS7Jk6sdnvXjapUE4/zcbP0UY0gN 3hpKZrGkTWerwOJPNBZbqGXQxc9Vnye8R4pT3j40/By828y+MjDJXo9ZEUGZnNvk Sb1LAt2ID6YaU+oN78i78mPy6Nwb/LrLk/HUfGbekXpMyAtmSEIfQYjPU9IsjSg/ 8vq1LHf30ZQs57U82Lf+f/KBKaLZF3+IFqXsL+wDX/HL1535nrX43PfVEmcFwYNs NgnfPkXqZAXwOsXVTfk2acJqJw2zjwTpZ/OiaeplV/D/JQD/PWEOc7Sd78e8qxCA rmxoJiQbIAK5Dh7wM1RiS/hpYmbU2B0o2V1Ep/9tVXQkOkioUAbAsdfcbyOHuAiA q0V51oOI2GmzWmfFD5ZHJAlMhz3dQF3O2VUAR5go/r+1pSwSXmyY6HAz6RXT0oVp VgohMPYVsyMbfNEeoevLEx7/u1YG0P6rdoWfyTK6MuGGMR0XuhL9n8uyFRcqnX/2 9Xs2vHukSaDPAB0GL/jX =ipWH -----END PGP SIGNATURE----- --=-=-=--