From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753307AbcALVku (ORCPT ); Tue, 12 Jan 2016 16:40:50 -0500 Received: from canardo.mork.no ([148.122.252.1]:38861 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbcALVks convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2016 16:40:48 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: David Miller Cc: lkundrak@v3.sk, jay.vosburgh@canonical.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vfalico@gmail.com, gospo@cumulusnetworks.com Subject: Re: [PATCH 3/3] bonding: make device count build-time configurable Organization: m References: <1452599916-27511-1-git-send-email-lkundrak@v3.sk> <8166.1452616452@famine> <1452619189.18559.83.camel@v3.sk> <20160112.154914.397367508465928770.davem@davemloft.net> Date: Tue, 12 Jan 2016 22:40:35 +0100 In-Reply-To: <20160112.154914.397367508465928770.davem@davemloft.net> (David Miller's message of "Tue, 12 Jan 2016 15:49:14 -0500 (EST)") Message-ID: <87bn8qv5m4.fsf@nemi.mork.no> User-Agent: Gnus/5.130013 (Ma Gnus v0.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller writes: > From: Lubomir Rintel > Date: Tue, 12 Jan 2016 18:19:49 +0100 > >> It's still an improvement to let the distributions decide if they're >> keeping "ip link add" broken or possibly affecting the scripts. > > That it is "broken" is your opinion. > > Document the behavior. It is not broken if the user is told to be > mindful of what devices are created by default. > > There is way too much downside to changing this. Besides, distributions or admins can already change that behaviour if they consider it "broken", using the existing module parameter: # echo "options bonding max_bonds=0" >/etc/modprobe.d/bonding.conf # rmmod bonding # ip link add bond0 type bond (no error here) This method should be well known and understood by most users, contrary to some odd CONFIG_ build time setting. Bjørn