From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbbJGBYt (ORCPT ); Tue, 6 Oct 2015 21:24:49 -0400 Received: from gabe.freedesktop.org ([131.252.210.177]:36449 "EHLO gabe.freedesktop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbbJGBYr (ORCPT ); Tue, 6 Oct 2015 21:24:47 -0400 From: Eric Anholt To: Stefan Wahren , linux-clk@vger.kernel.org Cc: devicetree@vger.kernel.org, Mike Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4] clk: bcm2835: Add support for programming the audio domain clocks. In-Reply-To: <56143AC9.60506@lategoodbye.de> References: <1443815696-11528-1-git-send-email-eric@anholt.net> <56143AC9.60506@lategoodbye.de> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 06 Oct 2015 18:24:44 -0700 Message-ID: <87bncbo4gz.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Stefan Wahren writes: > Hi Eric, > > Am 02.10.2015 um 21:54 schrieb Eric Anholt: >> This adds support for enabling, disabling, and setting the rate of the >> audio domain clocks. It will be necessary for setting the pixel clock >> for HDMI in the VC4 driver and let us write a cpufreq driver. It will >> also improve compatibility with user changes to the firmware's >> config.txt, since our previous fixed clocks are unaware of it. >> >> The firmware also has support for configuring the clocks through the >> mailbox channel, but the pixel clock setup by the firmware doesn't >> work, and it's Raspberry Pi specific anyway. The only conflicts we >> should have with the firmware would be if we made firmware calls that >> result in clock management (like opening firmware V3D or ISP access, >> which we don't support in upstream), or on hardware over-thermal or >> under-voltage (when the firmware would rewrite PLLB to take the ARM >> out of overclock). If that happens, our cached .recalc_rate() results >> would be incorrect, but that's no worse than our current state where >> we used fixed clocks. >> >> The existing fixed clocks in the code are left in place to provide >> backwards compatibility with old device tree files. > > only a few nits. I think I've done all of these now, sending out v5. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWFHRcAAoJELXWKTbR/J7omdUQAJLhe4jma2B2Adg05rHi6OgF aXfzBN8AK+rDKf2Cv14nmejuBZrg2oNu+DCaOfic0ewl8OtrB4QDAdbHqAlXisUH W5dTqKxHN2K9Gxx8A3OJFKzoJCjfXmuD0W3eIdJQDZ7sDh7eOrhiPbWYjl33hg7A yE7CnminSRbm1n/vwZgYvLmNNtue6j5zV0E+g6p8+lkjX4ggHPub0tgjJQBAnkGa 0FgqaNjsQuJyK/ghS1FUWDIRCWrCyx71cDe3dAnJRgbTEIIRojTEdv4xzBNf6PT/ 76xxTOnf55RVi+ePxbR6gFgxyxHgkz5sQXHYDoKbiTdykiGpTDsuF3qrFqTlZ9xh aaTiQrQrTtGx+/PSjuNWQhR1ua8HD794yKifQToi80l9XGwL9RZ5T107uwiKFUaf 7xbdMO10B/TDI99ZFDXeyZ+jeFR9UrOKR/0C2gCzlImLDlhz1uNVM2Qbn4pNruBA OaWuNlbRXG7uD2D2VnPMXDarbSPqAKiCMJWv79DTkMoExzQCMyeFf8E6Mp7wA1mS gSS88OPZkLfT2zHnlwbeoFAftVH7DZYjuM1TTkGn5GjcrOzSKHDxBnVcV1xFWeUD FbP6I3fHeXIQi5syP4NRjyPMQWnFF/H5GISrgvzTqTJ2ZBu5f+Omw9CSYIeqjNia +VKpmDG2ru08HZv4kbkr =Dkgw -----END PGP SIGNATURE----- --=-=-=--