From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH 1/4] lib/vsprintf.c: handle invalid format specifiers more robustly
Date: Mon, 28 Sep 2015 22:12:23 +0200 [thread overview]
Message-ID: <87bncmfgm0.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <1443427691.8361.226.camel@linux.intel.com> (Andy Shevchenko's message of "Mon, 28 Sep 2015 11:08:11 +0300")
On Mon, Sep 28 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>> /*
>> - * Since %n poses a greater security risk than
>> utility, treat
>> - * it as an invalid format specifier. Warn about its
>> use so
>> - * that new instances don't get added.
>> + * Since %n poses a greater security risk than
>
> Any reason to wrap first string?
I just hit M-q in emacs and let that take care of somewhat sane
wrapping. I don't play diff golf.
>> + /*
>> + * Presumably the arguments passed gcc's
>> type
>> + * checking, but there is no safe or sane
>> way
>> + * for us to continue parsing the format and
>> + * fetching from the va_list; the remaining
>> + * specifiers and arguments would be out of
>> + * sync.
>
> Could we use wider strings in the commentary here?
Ditto.
Rasmus
next prev parent reply other threads:[~2015-09-28 20:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 17:41 [PATCH 0/4] printf stuff Rasmus Villemoes
2015-09-25 17:41 ` [PATCH 1/4] lib/vsprintf.c: handle invalid format specifiers more robustly Rasmus Villemoes
2015-09-28 8:08 ` Andy Shevchenko
2015-09-28 20:12 ` Rasmus Villemoes [this message]
2015-09-28 22:30 ` Kees Cook
2015-09-25 17:41 ` [PATCH 2/4] lib/vsprintf.c: also improve sanity check in bstr_printf() Rasmus Villemoes
2015-09-28 22:31 ` Kees Cook
2015-09-25 17:41 ` [PATCH 3/4] lib/vsprintf.c: Remove SPECIAL handling in pointer() Rasmus Villemoes
2015-09-28 8:55 ` Andy Shevchenko
2015-09-25 17:41 ` [PATCH 4/4] test_printf: test printf family at runtime Rasmus Villemoes
2015-09-28 9:12 ` Andy Shevchenko
2015-09-28 20:55 ` Rasmus Villemoes
2015-09-30 6:38 ` Andy Shevchenko
2015-09-30 8:56 ` Rasmus Villemoes
2015-09-28 22:38 ` Kees Cook
2015-09-29 7:10 ` Rasmus Villemoes
2015-09-29 17:32 ` Kees Cook
2015-09-30 9:05 ` Rasmus Villemoes
2015-09-30 15:30 ` [PATCH v2 0/4] printf stuff Rasmus Villemoes
2015-09-30 15:30 ` [PATCH v2 1/4] lib/vsprintf.c: handle invalid format specifiers more robustly Rasmus Villemoes
2015-09-30 15:30 ` [PATCH v2 2/4] lib/vsprintf.c: also improve sanity check in bstr_printf() Rasmus Villemoes
2015-09-30 15:30 ` [PATCH v2 3/4] lib/vsprintf.c: Remove SPECIAL handling in pointer() Rasmus Villemoes
2015-09-30 15:40 ` Andy Shevchenko
2015-09-30 15:30 ` [PATCH v2 4/4] test_printf: test printf family at runtime Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bncmfgm0.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome