From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755390AbbHQMEX (ORCPT ); Mon, 17 Aug 2015 08:04:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:37584 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755163AbbHQMEV (ORCPT ); Mon, 17 Aug 2015 08:04:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,694,1432623600"; d="scan'208";a="750078271" From: Alexander Shishkin To: Huaitong Han Cc: linux-kernel@vger.kernel.org, Huaitong Han , Peter Zijlstra , mingo@redhat.com, acme@kernel.org Subject: Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning In-Reply-To: <1439546857-12791-1-git-send-email-huaitong.han@intel.com> References: <1439546857-12791-1-git-send-email-huaitong.han@intel.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 17 Aug 2015 15:04:16 +0300 Message-ID: <87bne6jf3z.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Huaitong Han writes: > rdmsrl_safe does not lead to #GP in native kernel although CPU > does not support INTEL_PT, but if KVM does not support INTEL_PT, > the codes cannot understand MSR_IA32_RTIT_CTL, and the warning > is produced. "the codes"? > If KVM does not support INTEL_PT, its guest CPUID also does not. > So test_cpu_cap is added before RDMSR, and it is more in line with > the code style. It does make more sense like this, but please improve this commit message. And don't forget to include Peter in the loop. FWIW, Reviewed-by: Alexander Shishkin Regards, -- Alex